From 0131e985085ec7f68a0377db8c105b7194012355 Mon Sep 17 00:00:00 2001 From: kubersharma001 Date: Sun, 6 Mar 2022 13:51:34 +0530 Subject: [PATCH] universal7885: Don't inherit updatable_apex.mk This is because of the following reasons: - Many build scripts force disable it anyways by settings OVERRIDE_TARGET_FLATTEN_APEX env flag so why bother rendering differences in official and local builds [1][2]. - Compressed apex causes issues with OTA on A only devices [3]. - Compressed apex may cause issues on devices which do not meet kernel requirements [4]. - Highly anticipated mainline modules update aka Play System updates is limited to OEMs/Pixels only [5], we don't do such things on AOSP; shipping Pixel prebuilt apex components feels somewhat unethical. Ref: [1]: https://github.com/lineageos-infra/build-config/blob/8e435ce7ff7c74097b3500e143380273e099aefb/android/build.sh#L9 [2]: https://github.com/LineageOS/android_build/blob/lineage-18.1/target/product/updatable_apex.mk#L19 [3]: RecoverySystemService: Failed to reserve space for compressed apex [4]: https://source.android.com/devices/tech/ota/apex#kernel-requirements [5]: "pushed to end-user devices, either by Google (using the Google Play Store infrastructure) or by the Android partner (using a partner-provided OTA mechanism)." as stated in https://source.android.com/devices/architecture/modular-system#architecture test: m, boots and ota. Signed-off-by: YadavMohit19 Change-Id: Ib15f59ccfaaab43eea8d0a7a1671529da5bc0365 Signed-off-by: roynatech2544 --- universal7885-common/universal7885-common.mk | 3 --- 1 file changed, 3 deletions(-) diff --git a/universal7885-common/universal7885-common.mk b/universal7885-common/universal7885-common.mk index c6e6f09..3126c0b 100644 --- a/universal7885-common/universal7885-common.mk +++ b/universal7885-common/universal7885-common.mk @@ -5,9 +5,6 @@ else ifneq ($(findstring a40, $(TARGET_PRODUCT)),) $(call inherit-product, vendor/samsung/universal7904-common/universal7904-common-vendor.mk) endif -# .apex packages -$(call inherit-product, $(SRC_TARGET_DIR)/product/updatable_apex.mk) - # Build Fingerprints $(call inherit-product, $(LOCAL_PATH)/fingerprint.mk)