bunnypad/android_device_samsung_a20
Watch
1
0
Fork
You've already forked android_device_samsung_a20
 0
mirror of https://github.com/chararomandroid/android_device_samsung_a20 synced 2026-08-22 12:05:32 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

universal7885: parts-aidl: Just use new operator

Browse source 
Using std::unique_ptr may result in deleted pointer
This commit is contained in:
roynatech2544 2022-10-14 21:11:43 +09:00
commit 06c69bfd89
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
universal7885-common/apps/aidl-support/parts/default/SmartCharge.cpp
View file

@ -17,11 +17,10 @@
#include <fstream> #include <fstream>
#include <iostream> #include <iostream>
#include <memory>
namespace aidl::vendor::eureka::hardware::parts { namespace aidl::vendor::eureka::hardware::parts {
static std::unique_ptr<SmartChargeImpl> kInst; static SmartChargeImpl *kInst;
static int limit = 0; static int limit = 0;
static int restart = 0; static int restart = 0;
@ -33,7 +32,7 @@ static int restart_stat = 0;
if (limit == 0 || restart == 0) if (limit == 0 || restart == 0)
return ::ndk::ScopedAStatus::fromExceptionCodeWithMessage( return ::ndk::ScopedAStatus::fromExceptionCodeWithMessage(
EX_ILLEGAL_ARGUMENT, "Start called without configuring."); EX_ILLEGAL_ARGUMENT, "Start called without configuring.");
kInst = std::make_unique<SmartChargeImpl>(limit, restart); kInst = new SmartChargeImpl(limit, restart);
kInst->start(); kInst->start();
return ::ndk::ScopedAStatus::ok(); return ::ndk::ScopedAStatus::ok();
} }
@ -43,7 +42,8 @@ static int restart_stat = 0;
kInst->stop(); kInst->stop();
limit_stat += kInst->charge_limit_cnt; limit_stat += kInst->charge_limit_cnt;
restart_stat += kInst->restart_cnt; restart_stat += kInst->restart_cnt;
kInst.reset(); delete kInst;
kInst = nullptr;
} }
return ::ndk::ScopedAStatus::ok(); return ::ndk::ScopedAStatus::ok();
} }