From 092cf54ced201d8c6bfaab3af4ea9d2750134b64 Mon Sep 17 00:00:00 2001 From: roynatech2544 Date: Sun, 23 Oct 2022 13:23:37 +0900 Subject: [PATCH] universal7885: Remove eureka_defaults treewide clang-tidy checks doesn't make it best code --- Android.bp | 69 ------------------- a10/sensor/Android.bp | 1 - a10/usb/Android.bp | 1 - a10dd/usb/Android.bp | 3 +- .../apps/SamsungParts/jni/Android.bp | 2 - .../audio_route/default/Android.bp | 3 - .../apps/aidl-support/fm/default/Android.bp | 1 - .../fm/default/libfm_slsi-impl/Android.bp | 1 - .../aidl-support/parts/default/Android.bp | 1 - .../debug-tools/bootlogger/Android.bp | 1 - .../hidl-packages/camera/provider/Android.bp | 1 - .../hidl-packages/powerstats/Android.bp | 1 - universal7885-common/libinit/Android.bp | 1 - 13 files changed, 1 insertion(+), 85 deletions(-) delete mode 100644 Android.bp diff --git a/Android.bp b/Android.bp deleted file mode 100644 index 100abd0..0000000 --- a/Android.bp +++ /dev/null @@ -1,69 +0,0 @@ -// From system/apex/apexd/Android.bp - -tidy_errors = [ - "android-*", - "bugprone-infinite-loop", - "bugprone-macro-parentheses", - "bugprone-misplaced-widening-cast", - "bugprone-move-forwarding-reference", - "bugprone-sizeof-container", - "bugprone-sizeof-expression", - "bugprone-string-constructor", - "bugprone-terminating-continue", - "bugprone-undefined-memory-manipulation", - "bugprone-undelegated-constructor", - "bugprone-unhandled-self-assignment", - "bugprone-unused-raii", - "cert-err34-c", - "google-default-arguments", - "google-explicit-constructor", - "google-readability-avoid-underscore-in-googletest-name", - "google-readability-todo", - "google-runtime-int", - "google-runtime-member-string-references", - "misc-move-const-arg", - "misc-move-forwarding-reference", - "misc-unused-parameters", - "misc-unused-using-decls", - "misc-use-after-move", - "modernize-pass-by-value", - "performance-faster-string-find", - "performance-for-range-copy", - "performance-implicit-conversion-in-loop", - "performance-inefficient-vector-operation", - "performance-move-const-arg", - "performance-move-constructor-init", - "performance-noexcept-move-constructor", - "performance-unnecessary-copy-initialization", - "readability-avoid-const-params-in-decls", -] - -cc_defaults { - name: "eureka_defaults", - cflags: [ - "-Wall", - "-Wextra", - "-Werror", - "-Wno-unused-parameter", - - // Some extra flags. - "-fstrict-aliasing", - "-Wredundant-decls", - "-Wshadow", - "-Wstrict-aliasing", - "-Wthread-safety", - "-Wunreachable-code", - "-Wunreachable-code-break", - "-Wunreachable-code-return", - "-Wunused", - "-Wused-but-marked-unused", - ], - tidy: true, - tidy_checks: tidy_errors, - tidy_checks_as_errors: tidy_errors, - tidy_flags: [ - "-format-style=file", - ], -} - - diff --git a/a10/sensor/Android.bp b/a10/sensor/Android.bp index 2802fc8..a9bfa0d 100644 --- a/a10/sensor/Android.bp +++ b/a10/sensor/Android.bp @@ -2,7 +2,6 @@ cc_binary { name: "android.hardware.sensors@1.0-service.a10", relative_install_path: "hw", vendor: true, - defaults: ["eureka_defaults"], init_rc: ["android.hardware.sensors@1.0-service.a10.rc"], srcs: ["service.cpp"], compile_multilib: "32", diff --git a/a10/usb/Android.bp b/a10/usb/Android.bp index 274df2f..2f760e3 100644 --- a/a10/usb/Android.bp +++ b/a10/usb/Android.bp @@ -18,7 +18,6 @@ cc_binary { relative_install_path: "hw", init_rc: ["android.hardware.usb@1.0-service.a10.rc"], vintf_fragments: ["android.hardware.usb@1.0-service.a10.xml"], - defaults: ["eureka_defaults"], srcs: [ "service.cpp", "Usb.cpp", diff --git a/a10dd/usb/Android.bp b/a10dd/usb/Android.bp index f60eda8..291e991 100644 --- a/a10dd/usb/Android.bp +++ b/a10dd/usb/Android.bp @@ -17,8 +17,7 @@ cc_binary { name: "android.hardware.usb@1.0-service.a10dd", relative_install_path: "hw", init_rc: ["android.hardware.usb@1.0-service.a10dd.rc"], - vintf_fragments: ["android.hardware.usb@1.0-service.a10dd.xml"], - defaults: ["eureka_defaults"], + vintf_fragments: ["android.hardware.usb@1.0-service.a10dd.xml"] srcs: [ "service.cpp", "Usb.cpp", diff --git a/universal7885-common/apps/SamsungParts/jni/Android.bp b/universal7885-common/apps/SamsungParts/jni/Android.bp index e5a2729..1534d14 100644 --- a/universal7885-common/apps/SamsungParts/jni/Android.bp +++ b/universal7885-common/apps/SamsungParts/jni/Android.bp @@ -1,6 +1,5 @@ cc_library_shared { name: "libStorageHelper", - defaults: ["eureka_defaults"], cflags: [ "-Wall", "-Wextra", @@ -14,7 +13,6 @@ cc_library_shared { cc_library_shared { name: "libSwapCallback", - defaults: ["eureka_defaults"], srcs: [ "SwapCallbackImpl.cpp", "SwapCallbackNative.cpp", diff --git a/universal7885-common/apps/aidl-support/audio_route/default/Android.bp b/universal7885-common/apps/aidl-support/audio_route/default/Android.bp index 89335c2..7cc8edc 100644 --- a/universal7885-common/apps/aidl-support/audio_route/default/Android.bp +++ b/universal7885-common/apps/aidl-support/audio_route/default/Android.bp @@ -4,9 +4,6 @@ cc_binary { "AudioRoute.cpp", "service.cpp", ], - defaults: [ - "eureka_defaults", - ], shared_libs: [ "libbase", "libbinder_ndk", diff --git a/universal7885-common/apps/aidl-support/fm/default/Android.bp b/universal7885-common/apps/aidl-support/fm/default/Android.bp index 1f0bdaa..fc10610 100644 --- a/universal7885-common/apps/aidl-support/fm/default/Android.bp +++ b/universal7885-common/apps/aidl-support/fm/default/Android.bp @@ -15,7 +15,6 @@ cc_binary { "service.cpp", ], defaults: [ - "eureka_defaults", "fm_aidl_defaults", ], static_libs: ["libfm_slsi-impl"], diff --git a/universal7885-common/apps/aidl-support/fm/default/libfm_slsi-impl/Android.bp b/universal7885-common/apps/aidl-support/fm/default/libfm_slsi-impl/Android.bp index 8847b39..33c3ce0 100644 --- a/universal7885-common/apps/aidl-support/fm/default/libfm_slsi-impl/Android.bp +++ b/universal7885-common/apps/aidl-support/fm/default/libfm_slsi-impl/Android.bp @@ -9,7 +9,6 @@ cc_library_static { shared_libs: ["libbase"], export_include_dirs: ["public"], defaults: [ - "eureka_defaults", "fm_aidl_defaults" ], header_libs: ["logformat"], diff --git a/universal7885-common/apps/aidl-support/parts/default/Android.bp b/universal7885-common/apps/aidl-support/parts/default/Android.bp index 8a5cea6..cd355a7 100644 --- a/universal7885-common/apps/aidl-support/parts/default/Android.bp +++ b/universal7885-common/apps/aidl-support/parts/default/Android.bp @@ -1,6 +1,5 @@ cc_binary { name: "vendor.eureka.hardware.parts-service", - defaults: ["eureka_defaults"], srcs: [ "Battery.cpp", "FlashLight.cpp", diff --git a/universal7885-common/debug-tools/bootlogger/Android.bp b/universal7885-common/debug-tools/bootlogger/Android.bp index 1238f42..5b03952 100644 --- a/universal7885-common/debug-tools/bootlogger/Android.bp +++ b/universal7885-common/debug-tools/bootlogger/Android.bp @@ -19,6 +19,5 @@ cc_binary { srcs: [ "Logger.cpp", ], - defaults: ["eureka_defaults"], init_rc: ["eklogger.rc"], } diff --git a/universal7885-common/hidl-packages/camera/provider/Android.bp b/universal7885-common/hidl-packages/camera/provider/Android.bp index 2022f11..1464255 100644 --- a/universal7885-common/hidl-packages/camera/provider/Android.bp +++ b/universal7885-common/hidl-packages/camera/provider/Android.bp @@ -17,7 +17,6 @@ cc_binary { name: "android.hardware.camera.provider@2.5-service.exynos7885", defaults: [ "hidl_defaults", - "eureka_defaults", ], compile_multilib: "32", proprietary: true, diff --git a/universal7885-common/hidl-packages/powerstats/Android.bp b/universal7885-common/hidl-packages/powerstats/Android.bp index c264cfb..6f40257 100644 --- a/universal7885-common/hidl-packages/powerstats/Android.bp +++ b/universal7885-common/hidl-packages/powerstats/Android.bp @@ -6,7 +6,6 @@ cc_binary { relative_install_path: "hw", vendor: true, defaults: [ - "eureka_defaults", "powerstats_pixel_defaults", ], cflags: ["-Wno-thread-safety-negative"], diff --git a/universal7885-common/libinit/Android.bp b/universal7885-common/libinit/Android.bp index 2639424..e29724b 100644 --- a/universal7885-common/libinit/Android.bp +++ b/universal7885-common/libinit/Android.bp @@ -15,7 +15,6 @@ cc_library_static { name: "libinit_universal7885", recovery_available: true, - defaults: ["eureka_defaults"], whole_static_libs: ["libbase"], header_libs: ["libbase_headers"], srcs: ["init_universal7885.cpp"],