From 5394c3b11fce0dd0d1c57ca4201ec9fb226ecda3 Mon Sep 17 00:00:00 2001 From: roynatech2544 Date: Fri, 20 May 2022 13:05:35 +0000 Subject: [PATCH] universal7885: Add extra compiler defaults --- Android.bp | 71 +++++++++++++++++++ a10/sensor/Android.bp | 1 + a10/usb/Android.bp | 1 + .../apps/FMRadio/jni/Android.bp | 1 + .../apps/SamsungParts/jni/Android.bp | 1 + .../camera/provider/Android.bp | 1 + universal7885-common/eklogger/Android.bp | 1 + universal7885-common/health/Android.bp | 2 +- .../hardware/fmradio/1.2/default/Android.bp | 1 + .../hardware/parts/1.0/default/Android.bp | 1 + universal7885-common/libinit/Android.bp | 1 + 11 files changed, 81 insertions(+), 1 deletion(-) create mode 100644 Android.bp diff --git a/Android.bp b/Android.bp new file mode 100644 index 0000000..d52749f --- /dev/null +++ b/Android.bp @@ -0,0 +1,71 @@ +// From system/apex/apexd/Android.bp + +tidy_errors = [ + "android-*", + "bugprone-infinite-loop", + "bugprone-macro-parentheses", + "bugprone-misplaced-widening-cast", + "bugprone-move-forwarding-reference", + "bugprone-sizeof-container", + "bugprone-sizeof-expression", + "bugprone-string-constructor", + "bugprone-terminating-continue", + "bugprone-undefined-memory-manipulation", + "bugprone-undelegated-constructor", + "bugprone-unhandled-self-assignment", + "bugprone-unused-raii", + "cert-err34-c", + "google-default-arguments", + "google-explicit-constructor", + "google-readability-avoid-underscore-in-googletest-name", + "google-readability-todo", + "google-runtime-int", + "google-runtime-member-string-references", + "misc-move-const-arg", + "misc-move-forwarding-reference", + "misc-unused-parameters", + "misc-unused-using-decls", + "misc-use-after-move", + "modernize-pass-by-value", + "performance-faster-string-find", + "performance-for-range-copy", + "performance-implicit-conversion-in-loop", + "performance-inefficient-vector-operation", + "performance-move-const-arg", + "performance-move-constructor-init", + "performance-noexcept-move-constructor", + "performance-unnecessary-copy-initialization", + "performance-unnecessary-value-param", + "readability-avoid-const-params-in-decls", +] + +cc_defaults { + name: "eureka_defaults", + cflags: [ + "-Wall", + "-Wextra", + "-Werror", + "-Wno-unused-parameter", + + // Some extra flags. + "-fstrict-aliasing", + "-Wredundant-decls", + "-Wshadow", + "-Wstrict-aliasing", + "-Wthread-safety", + "-Wthread-safety-negative", + "-Wunreachable-code", + "-Wunreachable-code-break", + "-Wunreachable-code-return", + "-Wunused", + "-Wused-but-marked-unused", + ], + tidy: true, + tidy_checks: tidy_errors, + tidy_checks_as_errors: tidy_errors, + tidy_flags: [ + "-format-style=file", + ], +} + + diff --git a/a10/sensor/Android.bp b/a10/sensor/Android.bp index a9bfa0d..2802fc8 100644 --- a/a10/sensor/Android.bp +++ b/a10/sensor/Android.bp @@ -2,6 +2,7 @@ cc_binary { name: "android.hardware.sensors@1.0-service.a10", relative_install_path: "hw", vendor: true, + defaults: ["eureka_defaults"], init_rc: ["android.hardware.sensors@1.0-service.a10.rc"], srcs: ["service.cpp"], compile_multilib: "32", diff --git a/a10/usb/Android.bp b/a10/usb/Android.bp index 2f760e3..274df2f 100644 --- a/a10/usb/Android.bp +++ b/a10/usb/Android.bp @@ -18,6 +18,7 @@ cc_binary { relative_install_path: "hw", init_rc: ["android.hardware.usb@1.0-service.a10.rc"], vintf_fragments: ["android.hardware.usb@1.0-service.a10.xml"], + defaults: ["eureka_defaults"], srcs: [ "service.cpp", "Usb.cpp", diff --git a/universal7885-common/apps/FMRadio/jni/Android.bp b/universal7885-common/apps/FMRadio/jni/Android.bp index 5b4ee8a..49b0040 100644 --- a/universal7885-common/apps/FMRadio/jni/Android.bp +++ b/universal7885-common/apps/FMRadio/jni/Android.bp @@ -7,6 +7,7 @@ cc_library_shared { "fm_ioctl.cpp", "fm_route.cpp", ], + defaults: ["eureka_defaults"], shared_libs: [ "libhidlbase", "liblog", diff --git a/universal7885-common/apps/SamsungParts/jni/Android.bp b/universal7885-common/apps/SamsungParts/jni/Android.bp index a57201c..28ce7eb 100644 --- a/universal7885-common/apps/SamsungParts/jni/Android.bp +++ b/universal7885-common/apps/SamsungParts/jni/Android.bp @@ -1,5 +1,6 @@ cc_library_shared { name: "libsamsungparts_jni", + defaults: ["eureka_defaults"], cflags: [ "-Wall", "-Wextra", diff --git a/universal7885-common/camera/provider/Android.bp b/universal7885-common/camera/provider/Android.bp index 5fe3afe..55897da 100644 --- a/universal7885-common/camera/provider/Android.bp +++ b/universal7885-common/camera/provider/Android.bp @@ -17,6 +17,7 @@ cc_binary { name: "android.hardware.camera.provider@2.5-service.exynos7885", defaults: [ "hidl_defaults", + "eureka_defaults", ], proprietary: true, relative_install_path: "hw", diff --git a/universal7885-common/eklogger/Android.bp b/universal7885-common/eklogger/Android.bp index 5b03952..1238f42 100644 --- a/universal7885-common/eklogger/Android.bp +++ b/universal7885-common/eklogger/Android.bp @@ -19,5 +19,6 @@ cc_binary { srcs: [ "Logger.cpp", ], + defaults: ["eureka_defaults"], init_rc: ["eklogger.rc"], } diff --git a/universal7885-common/health/Android.bp b/universal7885-common/health/Android.bp index 89ccd41..1f2372d 100644 --- a/universal7885-common/health/Android.bp +++ b/universal7885-common/health/Android.bp @@ -5,7 +5,7 @@ cc_library_shared { proprietary: true, recovery_available: true, relative_install_path: "hw", - + defaults: ["eureka_defaults"], shared_libs: [ "libbase", "libcutils", diff --git a/universal7885-common/interfaces/hardware/fmradio/1.2/default/Android.bp b/universal7885-common/interfaces/hardware/fmradio/1.2/default/Android.bp index 96c9929..3f2fbae 100644 --- a/universal7885-common/interfaces/hardware/fmradio/1.2/default/Android.bp +++ b/universal7885-common/interfaces/hardware/fmradio/1.2/default/Android.bp @@ -6,6 +6,7 @@ cc_binary { "FMRadio.cpp", "service.cpp", ], + defaults: ["eureka_defaults"], shared_libs: [ "libhidlbase", "libutils", diff --git a/universal7885-common/interfaces/hardware/parts/1.0/default/Android.bp b/universal7885-common/interfaces/hardware/parts/1.0/default/Android.bp index 9c56e36..fc10199 100644 --- a/universal7885-common/interfaces/hardware/parts/1.0/default/Android.bp +++ b/universal7885-common/interfaces/hardware/parts/1.0/default/Android.bp @@ -2,6 +2,7 @@ cc_binary { name: "vendor.eureka.hardware.parts@1.0-service", + defaults: ["eureka_defaults"], srcs: [ "Battery.cpp", "FlashLight.cpp", diff --git a/universal7885-common/libinit/Android.bp b/universal7885-common/libinit/Android.bp index e29724b..2639424 100644 --- a/universal7885-common/libinit/Android.bp +++ b/universal7885-common/libinit/Android.bp @@ -15,6 +15,7 @@ cc_library_static { name: "libinit_universal7885", recovery_available: true, + defaults: ["eureka_defaults"], whole_static_libs: ["libbase"], header_libs: ["libbase_headers"], srcs: ["init_universal7885.cpp"],