diff --git a/universal7885-common/apps/SamsungParts/jni/BatteryBridge.cpp b/universal7885-common/apps/SamsungParts/jni/BatteryBridge.cpp index a360ac1..d6cedc2 100644 --- a/universal7885-common/apps/SamsungParts/jni/BatteryBridge.cpp +++ b/universal7885-common/apps/SamsungParts/jni/BatteryBridge.cpp @@ -22,7 +22,7 @@ enum { static android::sp service = IBatteryStats::getService(); extern "C" JNIEXPORT void JNICALL Java_com_eurekateam_samsungextras_interfaces_Battery_setChargeSysfs( - JNIEnv *env, __unused jclass obj, jint enable) { + JNIEnv /*env*/, __unused jclass obj, jint enable) { if (enable == 1) { service->setBatteryWritable(SysfsType::CHARGE, Number::ENABLE); } else { @@ -32,14 +32,14 @@ Java_com_eurekateam_samsungextras_interfaces_Battery_setChargeSysfs( extern "C" JNIEXPORT jint JNICALL Java_com_eurekateam_samsungextras_interfaces_Battery_getChargeSysfs( - JNIEnv *env, __unused jclass obj) { + JNIEnv /*env*/, __unused jclass obj) { int ret = service->getBatteryStats(SysfsType::CHARGE); return ret; } extern "C" JNIEXPORT void JNICALL Java_com_eurekateam_samsungextras_interfaces_Battery_setFastCharge( - JNIEnv *env, __unused jobject obj, jint enable) { + JNIEnv /*env*/, __unused jobject obj, jint enable) { if (enable == 1) { service->setBatteryWritable(SysfsType::FASTCHARGE, Number::ENABLE); } else { @@ -48,13 +48,13 @@ Java_com_eurekateam_samsungextras_interfaces_Battery_setFastCharge( } extern "C" JNIEXPORT jint JNICALL Java_com_eurekateam_samsungextras_interfaces_Battery_getFastChargeSysfs( - JNIEnv *env, __unused jclass obj) { + JNIEnv /*env*/, __unused jclass obj) { int ret = service->getBatteryStats(SysfsType::FASTCHARGE); return ret; } extern "C" JNIEXPORT jint JNICALL Java_com_eurekateam_samsungextras_interfaces_Battery_getGeneralBatteryStats( - JNIEnv *env, __unused jobject obj, jint id) { + JNIEnv /*env*/, __unused jobject obj, jint id) { int ret; switch (id) { case BATTERY_CAPACITY_MAX: diff --git a/universal7885-common/apps/SamsungParts/jni/DisplayBridge.cpp b/universal7885-common/apps/SamsungParts/jni/DisplayBridge.cpp index a80d906..b82f7fe 100644 --- a/universal7885-common/apps/SamsungParts/jni/DisplayBridge.cpp +++ b/universal7885-common/apps/SamsungParts/jni/DisplayBridge.cpp @@ -13,8 +13,8 @@ using vendor::eureka::hardware::parts::V1_0::Number; static android::sp service = IDisplayConfigs::getService(); extern "C" JNIEXPORT void JNICALL -Java_com_eurekateam_samsungextras_interfaces_Display_setDT2W(JNIEnv *env, - jclass clazz, +Java_com_eurekateam_samsungextras_interfaces_Display_setDT2W(JNIEnv /*env*/, + jclass /*clazz*/, jboolean enable) { if (enable) { service->writeDisplay(Number::ENABLE, Display::DOUBLE_TAP); @@ -25,7 +25,7 @@ Java_com_eurekateam_samsungextras_interfaces_Display_setDT2W(JNIEnv *env, extern "C" JNIEXPORT void JNICALL Java_com_eurekateam_samsungextras_interfaces_Display_setGloveMode( - JNIEnv *env, jclass clazz, jboolean enable) { + JNIEnv /**env*/, jclass /*clazz*/, jboolean enable) { if (enable) { service->writeDisplay(Number::ENABLE, Display::GLOVE_MODE); } else { diff --git a/universal7885-common/apps/SamsungParts/jni/FlashlightBridge.cpp b/universal7885-common/apps/SamsungParts/jni/FlashlightBridge.cpp index 79c6968..c91b243 100644 --- a/universal7885-common/apps/SamsungParts/jni/FlashlightBridge.cpp +++ b/universal7885-common/apps/SamsungParts/jni/FlashlightBridge.cpp @@ -15,7 +15,7 @@ static android::sp service = IFlashBrightness::getService(); extern "C" JNIEXPORT void JNICALL Java_com_eurekateam_samsungextras_interfaces_Flashlight_setEnabled( - JNIEnv *env, __unused jobject obj, jboolean enabled) { + JNIEnv /*env*/, __unused jobject obj, jboolean enabled) { if (enabled) { service->setFlashlightEnable(Number::ENABLE); } else { @@ -25,12 +25,12 @@ Java_com_eurekateam_samsungextras_interfaces_Flashlight_setEnabled( extern "C" JNIEXPORT void JNICALL Java_com_eurekateam_samsungextras_interfaces_Flashlight_setFlash( - JNIEnv *env, __unused jobject obj, jint value) { + JNIEnv /*env*/, __unused jobject obj, jint value) { service->setFlashlightWritable(static_cast(value)); } extern "C" JNIEXPORT jint JNICALL -Java_com_eurekateam_samsungextras_interfaces_Flashlight_getFlash(JNIEnv *env, - jobject clazz, +Java_com_eurekateam_samsungextras_interfaces_Flashlight_getFlash(JNIEnv /*env*/, + jobject /*clazz*/, jint isA10) { int ret; if (isA10 == 1) { diff --git a/universal7885-common/apps/SamsungParts/jni/Storage.cpp b/universal7885-common/apps/SamsungParts/jni/Storage.cpp index ce30e1a..73c68bf 100644 --- a/universal7885-common/apps/SamsungParts/jni/Storage.cpp +++ b/universal7885-common/apps/SamsungParts/jni/Storage.cpp @@ -12,8 +12,8 @@ double roundDouble(double origin) { } extern "C" JNIEXPORT jdouble JNICALL -Java_com_eurekateam_samsungextras_interfaces_Swap_getFreeSpace(JNIEnv *env, - jclass clazz) { +Java_com_eurekateam_samsungextras_interfaces_Swap_getFreeSpace(JNIEnv /*env*/, + jclass /*clazz*/) { fs::space_info data = fs::space("/data"); auto freespace = data.free / 1024 / 1024; auto result = static_cast(freespace) / 1024; @@ -21,8 +21,8 @@ Java_com_eurekateam_samsungextras_interfaces_Swap_getFreeSpace(JNIEnv *env, } extern "C" JNIEXPORT jlong JNICALL -Java_com_eurekateam_samsungextras_interfaces_Swap_getSwapSize(JNIEnv *env, - jclass clazz) { +Java_com_eurekateam_samsungextras_interfaces_Swap_getSwapSize(JNIEnv /*env*/, + jclass /*clazz*/) { struct stat stat_buf; int rc = stat("/data/swap/swapfile", &stat_buf); return rc == 0 ? stat_buf.st_size / 1024 / 1024 : -1; diff --git a/universal7885-common/apps/SamsungParts/jni/SwapBridge.cpp b/universal7885-common/apps/SamsungParts/jni/SwapBridge.cpp index 1eb6987..6317be2 100644 --- a/universal7885-common/apps/SamsungParts/jni/SwapBridge.cpp +++ b/universal7885-common/apps/SamsungParts/jni/SwapBridge.cpp @@ -11,15 +11,15 @@ using vendor::eureka::hardware::parts::V1_0::ISwapOnData; static sp service = ISwapOnData::getService(); extern "C" JNIEXPORT void JNICALL -Java_com_eurekateam_samsungextras_interfaces_Swap_setSize(JNIEnv *env, - jclass clazz, +Java_com_eurekateam_samsungextras_interfaces_Swap_setSize(JNIEnv /*env*/, + jclass /*clazz*/, jint size) { service->setSwapSize(size); } extern "C" JNIEXPORT void JNICALL -Java_com_eurekateam_samsungextras_interfaces_Swap_setSwapOn(JNIEnv *env, - jclass clazz, +Java_com_eurekateam_samsungextras_interfaces_Swap_setSwapOn(JNIEnv /*env*/, + jclass /*clazz*/, jboolean enable) { if (enable) { service->setSwapOn(); diff --git a/universal7885-common/health/HealthImpl.cpp b/universal7885-common/health/HealthImpl.cpp index 1ec2bae..54074bb 100644 --- a/universal7885-common/health/HealthImpl.cpp +++ b/universal7885-common/health/HealthImpl.cpp @@ -8,15 +8,12 @@ #include #include -using ::android::sp; using ::android::hardware::Return; using ::android::hardware::Void; -using ::android::hardware::hidl_vec; using ::android::hardware::health::InitHealthdConfig; using ::android::hardware::health::V2_1::IHealth; using ::android::hardware::health::V2_0::Result; using ::android::hardware::health::V1_0::BatteryStatus; -using ::android::hidl::base::V1_0::IBase; using namespace std::literals; enum battery_stats { @@ -52,10 +49,10 @@ namespace implementation { // defaults. Uncomment functions that you need to override. class HealthImpl : public Health { public: - HealthImpl(std::unique_ptr&& config) + explicit HealthImpl(std::unique_ptr&& config) : Health(std::move(config)) {} - static struct callBack ReadFile(const std::string sysfs, const std::string def) { + static struct callBack ReadFile(const std::string &sysfs, const std::string &def) { std::string ret = def; std::ifstream file; file.open(sysfs); @@ -71,7 +68,7 @@ class HealthImpl : public Health { return cb; } - static struct callBack ReadBattFile(battery_stats type, const std::string def) { + static struct callBack ReadBattFile(battery_stats type, const std::string &def) { return ReadFile(battery_sysfs[type], def); }