Commit graph

470 commits

Author SHA1 Message Date
Prasad Arepalli
4763ef465f msm: ipa3: Removing assert in halt q6 channel failed cases.
Removing assert in halt q6 channel failed cases. Previously added it for debug purpose.

Change-Id: If58da0617d9b313038aa7d347e975ce85cbd8e91
2023-03-28 03:04:41 -07:00
Ashok Vuyyuru
338eb798c7 msm: ipa3: Adding changes to remove dependency ipa3_ctx global variable
ipa3_ctx variable not able to access from the client module and so
adding changes to get qmap id details from ipa core driver.

Change-Id: I215ed0137fdad531e23be35b496d4b8e4a43a554
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
2023-03-23 17:51:24 +05:30
Ashok Vuyyuru
18f7fea4d0 msm: ipa3: Changes to fix memory leak issue
During adding/deleting header rule found invalid entry not
freeing the header proc memory allocation due to that IPA
context bank page table was full, later it was failed
to map pages. To avoid this issue adding change to
free the memory in failed scenarios.

Change-Id: I8e5fd68d35579b4638e91590f5df876aa9d256a6
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
2023-02-03 02:41:32 +05:30
Jagadeesh Ponduru
d72da15579 msm: ipa3: reset skb header before passing it to NW stack
This ensures the network stack that skb->network_header
sits in the valid range of skb->data to skb->tail.

Change-Id: I6061eddc81cb2e9bd0e4d52ceddab792c332e15c
Signed-off-by: Jagadeesh Ponduru <quic_jponduru@quicinc.com>
2022-12-20 21:10:30 +05:30
Jagadeesh Ponduru
a4dde7e6f9 msm: ipa3: add debug stats in case of pipe setup fail
Adding changes to have a stats when the apps system
pipes failed to setup.

Change-Id: I5cbe23d77736f447665db5258e21386f220d1096
Signed-off-by: Jagadeesh Ponduru <quic_jponduru@quicinc.com>
2022-12-16 03:41:52 -08:00
Ashok Vuyyuru
6bc469fdf0 msm: ipa3: Update QMAP ID field in metadata field for GSB client
In XLAT scenario QMAP ID not updated in TX packets, due to that
it was not hitting not correct filter rules. Adding changes to
update QMAP ID field in metadata field for GSB client.

Change-Id: Ic6bfceb0b8e34316507eaf551fb2b62f085a3519
2022-12-01 23:40:13 -08:00
Jagadeesh Ponduru
47849962bb msm: ipa3: add cleanup_rx if setup pipe failed.
Whenever WAN CONS/WAN_COAL_CONS pipes setup fails,
cleaning up the allocated common buffer and temp pools.

Change-Id: I08c58d7bd36edbe820137d3fd760900598c4c8e6
Signed-off-by: Jagadeesh Ponduru <quic_jponduru@quicinc.com>
2022-11-27 22:53:17 -08:00
qctecmdr
811b817abf Merge "msm: ipa3: Adding check for odl stats" 2022-11-25 01:00:01 -08:00
Ashok Vuyyuru
96bf8d6ea0 msm: ipa3: Adding changes to retry page allocation in WQ
Currently WQ was exiting when page allocation was failed, due to
that number of WQ schedule will increase. To avoid this retrying the
page allocation in same WQ context.

Change-Id: Iefb85ae1552aa595a0959664c3ba55f6aa742551
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
2022-11-21 13:10:45 +05:30
Aparna Annapragada
fdd8f35392 msm: ipa3: Adding check for odl stats
Adding Null check while getting odl stats

change-Id: Ic1692cc4b1a1d3c8b559b20fbb2e1371e0b9f9b2
Signed-off-by: Aparna Annapragada <quic_aannapra@quicinc.com>
2022-11-02 22:39:39 -07:00
Jagadeesh Ponduru
f0f97b4005 msm: ipa3: add check in odl pipe cleanup
Adding a change to check whether the pipe has been
setup or not before going to teardown the pipe.

Change-Id: Ibb408fdf3509facd6c18e3238bdbfd7da0b4a643
Signed-off-by: Jagadeesh Ponduru <quic_jponduru@quicinc.com>
2022-07-04 20:20:34 -07:00
qctecmdr
fe3a4ad154 Merge "msm: ipa: fix to NULL terminate the pointer" 2022-06-29 04:10:25 -07:00
qctecmdr
109763e47c Merge "msm: ipahal: modify parameter from eq_bitfield[i] to i" 2022-06-28 21:21:41 -07:00
Ashok Vuyyuru
f9a39ef50f msm: ipa3: Added changes to check QMI pointer valid or not
After passing ipa_q6_clnt pointer to function, if it freed in
different thread it may lead to NULL pointer access. So adding
check to see passed pointer valid or not.

Change-Id: I22e272ebdecc62756ee140081524ab4efdd3d02a
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
2022-06-22 03:11:03 -07:00
Prashanth Reddy Baddam
f3f4d78a11 msm: ipa: fix to NULL terminate the pointer
Fix to NULL terminate the peers list ptr
after freeing it, to get rid of use after
free issue.

Change-Id: Ide9fde9e7648a7af561a5b0ae0fa085810e59ea6
Signed-off-by: Prashanth Reddy Baddam <quic_pbaddam@quicinc.com>
2022-06-21 06:20:30 -07:00
Jagadeesh Ponduru
6a73b4eff0 msm: ipahal: modify parameter from eq_bitfield[i] to i
From IPAv4.5 versions IPA_TOS_EQ is considered as not supported
and it made to 0XFF, instead IPA_IS_PURE_ACK is given support.
So, when validating the bitfield equations of them, passing
eq_bitfield[i] will throw shift overflow warning as it takes 0xFF.
So, added change to ensure there are no overflow warnings.

Change-Id: I84384723433706784a4ef21b88f33b036edb0a5d
Signed-off-by: Jagadeesh Ponduru <quic_jponduru@quicinc.com>
2022-06-11 00:23:46 +05:30
Raghavendar rao l
179ab9d536 msm: ipa3: handling MISRA issue
Added some NULL checks to avoid memcpy with zero size,
Updated checks for unsigned integer variables.

Change-Id: Ia426da6b1af04fb5226ba9bbf22f0fce11e4dff0
Signed-off-by: Raghavendar rao l <quic_rlomte@quicinc.com>
2022-06-01 15:01:15 +05:30
qctecmdr
f2729f4a13 Merge "msm: ipa3: Handle race condition to avoid NULL access" 2022-04-26 08:36:34 -07:00
qctecmdr
00b46c6d86 Merge "msm: ipa3: Reduce the QMI timeout value to avoid race condition" 2022-04-26 06:13:57 -07:00
Raghavendar rao l
1a79536d0e msm: ipa3: Handle race condition to avoid NULL access
Updated change to avoid race condition and NULL pointer access,
In case of SSR and ioctl call while performing QMI transaction.

Change-Id: I09dbf33d76a3a0d9e4917e62aaf1257a1abe2db9
Signed-off-by: Raghavendar rao l <quic_rlomte@quicinc.com>
2022-04-25 08:58:25 +05:30
Ashok Vuyyuru
9c3cb3f994 msm: ipa3: Reduce the QMI timeout value to avoid race condition
In SSR scenario if QMI response delayed SSR events getting timeout,
To avoid this issue reduce the QMI timeout value from 60sec to 10sec.

Change-Id: Ib0113a91f9bd60b3ea0e374bf249d4859a22a040
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
2022-04-22 03:05:53 -07:00
Vinayaka B M
c36b185506 msm: ipa: Set the logbuf NULL after destroy
Set the ipa3_ctx->logbuf NULL after destroy,or
IPAERR will use the ipa3_ctx->logbuf after free it,
that can make crash

Change-Id: I470c4a043d426d7620c01fadac1f1cd12ad54b08
2022-04-22 09:08:14 +05:30
Cheng Zeng
8aa0d102d8 msm: gsi: Fix the incorrect evt ring pointer
The pointer should be event ring pointer, not transfer
ring pointer, it has chance to get wrong upper 32 bits
when smmu is disabled.

Signed-off-by: Cheng Zeng <quic_chenzeng@quicinc.com>
2022-03-24 16:09:28 +08:00
Ashok Vuyyuru
1024d06f3f msm: ipa3: In deep sleep scenario destroy/ reinitialize uC interrupts
In deep sleep suspend/resume scenario destroy the uC interrupts
in suspend and reinitialize the interrupts in resume

Change-Id: Ib3631cef8e1e78651b6b79aef7f3d65dae0411c2
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
2022-03-17 19:19:06 +05:30
qctecmdr
c94d56d42b Merge "msm: ipa3: Changes to resume only suspend operation complete" 2022-02-08 18:03:49 -08:00
Ashok Vuyyuru
3b56c6e41a msm: ipa3: Changes to resume only suspend operation complete
In suspend abort scenario before receving suspend callback and resume
it again causing issues. To avoid this scenario only if suspend completed
doing resume operation.

Change-Id: I0cf08b4e9ab4f74c44d4bcb14f9472b8332b5f7b
2022-02-03 21:49:40 +05:30
qctecmdr
9c90eafb19 Merge "msm: ipa3: Disable gsi fifo and test bus registers" 2022-02-01 22:06:55 -08:00
Jagadeesh Ponduru
dc1c1a2252 msm: ipa3: Disable gsi fifo and test bus registers
Update change to disable gsi fifo and gsi test bus
registers as these cannot be accessed through IPA_AP.

Change-Id: Icd7c85101a8997eff08acc98dbc1ead7b6067c81
Signed-off-by: Jagadeesh Ponduru <quic_jponduru@quicinc.com>
2022-02-01 22:32:17 +05:30
Himansu Nayak
fd9586ccaf msm: ipa3: Fix to validate the NAT table entries during NAT table init
During NAT table Initialization parameter pass from HLOS, if max/zero
table entries passed it was leading to out of bound read. Adding checks
to validate the table entries before passing to NAT table parameter.

Signed-off-by: Himansu Nayak <quic_himansu@quicinc.com>
2022-01-31 08:07:32 +05:30
Raghavendar rao l
7705d29b41 msm: ipa3: Fix to avoid the boot up crash in non smmu targets
Updated change to perform ipa pre initialization even before
attempting to load the ipa firmware along with pdev node
initialization for non smmu target.

Change-Id: I04421c1f11f0c7b4d7a0f30135741946b157aa2c
Signed-off-by: Raghavendar rao l <quic_rlomte@quicinc.com>
2022-01-26 21:16:25 -08:00
qctecmdr
858b405f06 Merge "msm: ipa3: Deepsleep enable changes" 2022-01-24 23:22:45 -08:00
Srikanth Vakiti
fd9b880034 msm: ipa3: Disable of ODL offload checksum
ODL endpipe offload checksum disabled

Change-Id: I889bdea3ff6287188292ca17aa3df9b579a4fa8e
Signed-off-by: Vakiti Srikanth <quic_vakiti@quicinc.com>
2022-01-21 08:48:22 -08:00
Ashok Vuyyuru
2a2981c643 msm: ipa3: Deepsleep enable changes
Adding support to deepsleep scenario.

Change-Id: I2b388396cf9a7f26f77bbcd49c1014e16475a980
2022-01-21 21:48:07 +05:30
qctecmdr
a3a1d80439 Merge "msm: ipa3: Changes not allow ODL pipe setup during SSR" 2022-01-20 15:17:11 -08:00
qctecmdr
b770fe0aa5 Merge "msm: ipa3: enable ipa register save when device is about to crash" 2022-01-16 21:55:41 -08:00
Raghavendar rao l
8918458fc7 msm: ipa3: enable ipa register save when device is about to crash
Changes to save the IPA/GSI hardware contents onto ipa_reg_save
structure before to crash from APPS side, This support is
starting from IPA 4.5 version uptill 4.11.

Signed-off-by: Raghavendar rao l <quic_rlomte@quicinc.com>

Change-Id: I1680cf7bfab56d4a4888cf90874b92b999c3c9c9
2022-01-12 19:21:13 +05:30
qctecmdr
a17d83f9bb Merge "msm: ipa: use lower order pages" 2022-01-10 23:14:11 -08:00
Ashok Vuyyuru
0c348e3f80 msm: ipa3: Changes not allow ODL pipe setup during SSR
When SSR in progress not allowing to setup ODL pipe.

Change-Id: Ied44a7bafdf90cff2f3b7619da88fe3c31d18956
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
2022-01-07 00:54:28 +05:30
Ashok Vuyyuru
24278e36be msm: ipa: use lower order pages
When order 3 pages are not available, make changes to use
lower order pages to ensure buffers are provided to HW.

Change-Id: I9eea764d678820b0d3f485525310c506ea29c45e
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
2022-01-03 15:14:56 +05:30
Jagadeesh
1234f5d764 msm: ipa3: fix to cleanup the dma allocation.
When commit header table from memory to HW, adding fix to clean
dma allocation if it fails in multiple mapping attempts and also to
clean the allocated mapping of hdr table after commit to HW.

Change-Id: Icbf1b855e34625ffe8f8356a59cddf85a91b0160
Signed-off-by: Jagadeesh Ponduru <quic_jponduru@quicinc.com>
2021-12-22 23:15:45 +05:30
qctecmdr
1ed7eace10 Merge "msm: gsi: Read 64-bit ring RP value from registers" 2021-12-12 23:27:55 -08:00
Cheng Zeng
37dc636f49 msm: ipa: Get device pointers if smmu is disabled
If arm-smmu is not configured, smmu cb will not be
probed, still need to get pdev and uc_pdev.

Signed-off-by: Cheng Zeng <quic_chenzeng@quicinc.com>
2021-12-01 19:04:57 +08:00
Cheng Zeng
e091b01ac4 msm: gsi: Read 64-bit ring RP value from registers
The DMA address allocated may be in 64-bit address
range if dma mask is set to 64-bit, the MSB register
value is required.

Signed-off-by: Cheng Zeng <quic_chenzeng@quicinc.com>
2021-12-01 15:14:48 +08:00
qctecmdr
93c0b93ba9 Merge "msm: ipa: add skb recycle if dma fails during replenish" 2021-11-11 23:49:38 -08:00
Michael Adisumarta
676280f355 msm: ipa: add skb recycle if dma fails during replenish
Add skb recycle when dma mapping fails during rx cache
replenishing.

Change-Id: I4ea2b1581f4d9a404248ce39bb916e58e368b7e4
Signed-off-by: Michael Adisumarta <madisuma@codeaurora.org>
2021-11-11 09:48:53 -08:00
Michael Adisumarta
f34eede3cb msm: ipa: remove initing head again if dma mapping fails
Remove Initializing rx_pkt link if dma mapping fails.

Change-Id: I49d08555c875fc9039805ef8775be3b676f51d08
Signed-off-by: Michael Adisumarta <madisuma@codeaurora.org>
2021-11-11 09:48:14 -08:00
qctecmdr
c01e8606be Merge "msm: ipa3: Adding changes to support the deep sleep mode" 2021-10-29 14:28:41 -07:00
Raghavendar rao l
7f159650b1 msm: ipa3: Retry to attach smmu nodes if fails
Updated change to retry attaching smmu nodes if it fails, in a
deffered work queue with 500msec delay.

Change-Id: Ia54d801543224caf81085fedfd16305eca99995e
Signed-off-by: Raghavendar rao l <rlomte@codequrora.org>
2021-10-29 12:23:19 +05:30
Ashok Vuyyuru
1573aa5bb1 msm: ipa3: Adding changes to support the deep sleep mode
Adding changes to support the deep sleep mode on monaco
target.

Change-Id: I50016848fde9533a856203bc2ad89bf851179a7b
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
2021-10-29 00:29:29 +05:30
Ashok Vuyyuru
cfe6d558b2 msm: ipa3: Fix to NULL terminate the header pointer in proc header table
While resetting the header rules if it find invalid header ID it
will return before freeting proc header table it was leading to use
after free when accessing the header pointer from proc header table.
Adding changes to NULL terminating header pointer in proc header table
after header table deleted from the list.

Change-Id: If270d855d3907e61368336316161a250053e1e62
Signed-off-by: Ashok Vuyyuru <avuyyuru@codeaurora.org>
2021-10-20 01:13:15 +05:30