Order-3 allocations are costly when system is in full use.
Make changes to allocate page recycling buffers only once on boot up.
Change-Id: I445e27ecc03aaa00483e7a46a468ef0a6f4bfcfb
Signed-off-by: Chaitanya Pratapa <quic_cpratapa@quicinc.com>
Make changes to use __GFP_RETRY_MAYFAIL to avoid triggering
OOM Killer when allocating pages for temp allocations.
Change-Id: I2f5843c9a1c0a9f41e215c8241713f4670e4b35c
Signed-off-by: Chaitanya Pratapa <quic_cpratapa@quicinc.com>
Workqueue was getting scheduled after teardwon the pipe.
Adding changes to flush to workqueue during teardown pipe.
Change-Id: I5a6b3464d76a9835bfbf7668e8dbb1cdf00c73fe
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
Freepage workqueue created only for few pipes, while handling error
scenarios freeing it for all pipes. So adding check to free work queue
only if created.
Change-Id: I8bf097c02f6acd0a4a22b3d4bc5b66f46884fc1e
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
Adding changes to enhance find free pages from list,
1. When free page not available instead of keep trying
using temporary pages.
2. In tasklet search for free pages adding to head.
Change-Id: I991336167519322081faf8f82feec4e3f0d7b161
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
Added the following enhancements to page pool recycling logic.
1) Common page pool for coalescing/default pipe.
2) Common page pool will hold 5 times the rx_pool_sz (224) for page
recycling pool and 3 times for temp pool. This is done to sustain
50 stream scenarios.
Change-Id: I55adfffa101df33c46e95b0214fb7338644e8d7c
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
Added the following enhancements to page pool recycling logic.
1) Updated page pool implementation to use list instead of array.
2) Added provision to check for configurable number of list
elements when checking for free pages.
Change-Id: I01c43be5a169c1438fb29b8179854985e199d055
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
received from ioctl
WAN MTU IOCTL received NULL terminated the interface name
string to prevent out of bound memory access while printing
interface name.
Change-Id: I4ca8021e91689f2b1bf0bef7917a5fc7c2168aef
Signed-off-by: Avinash Kumar <quic_avku@quicinc.com>
(cherry picked from commit b639c459e4f7eedc361cee795489de3d379e7e0c)
Created new ipc ipa_clk log for adding more debug prints
for IPA Clocks in which provides the explicit time taken
by IPA ICC Voting for BW Paths and IPA Enable/Disable Clocks.
Change-Id: I53b7b5baba0ff72df286c86a4b45b0f860014474
Signed-off-by: Jagadeesh Ponduru <quic_jponduru@quicinc.com>
(cherry picked from commit 331da84e7fa7b3e3c833a38a7e828d72894ed297)
prefetch buffer is updated from 128 to 256 byte for route
and filter rule read.
Change-Id: Ibddddfda355e8032d6ec40da73394037534d1d78
Signed-off-by: Fakruddin Vohra <quic_fakruddi@quicinc.com>
The max header size changed from 64 to 255, which caused increase
in size of structs containing headers (struct ipa_hdr_add). Fixing the stack buffer
allocation size in the ioctl to avoid buffer overflow.
Note for the future: This function allocates number of buffers
on the stack, but uses only one on each call. It would be better
to refactor it, to use only one buffer, in order to minimize
stack allocations.
Change-Id: Id79efe7901ebf85dab4c0ba09cc7bb852cf22a97
Signed-off-by: Ilia Lin <quic_ilial@quicinc.com>
Signed-off-by: Chaitanya Pratapa <quic_cpratapa@quicinc.com>
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
In some scenarios WQ scheduling was delayed. To avoid these
issues adding changes to increase the WQ priority.
Change-Id: I597e73a354f2d136843b19a84c859fe3eb7b51e0
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
When offset gets added to base of the array, it returns
offset plus the number equal to size of the whole array.
So, correct it by passing the address of offset element
in the array.
Change-Id: I8a087ca277bdc476674c7221b5fc0920e6986570
ipa3_ctx variable not able to access from the client module and so
adding changes to get qmap id details from ipa core driver.
Change-Id: I215ed0137fdad531e23be35b496d4b8e4a43a554
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
During adding/deleting header rule found invalid entry not
freeing the header proc memory allocation due to that IPA
context bank page table was full, later it was failed
to map pages. To avoid this issue adding change to
free the memory in failed scenarios.
Change-Id: I8e5fd68d35579b4638e91590f5df876aa9d256a6
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
This ensures the network stack that skb->network_header
sits in the valid range of skb->data to skb->tail.
Change-Id: I6061eddc81cb2e9bd0e4d52ceddab792c332e15c
Signed-off-by: Jagadeesh Ponduru <quic_jponduru@quicinc.com>
Adding changes to have a stats when the apps system
pipes failed to setup.
Change-Id: I5cbe23d77736f447665db5258e21386f220d1096
Signed-off-by: Jagadeesh Ponduru <quic_jponduru@quicinc.com>
In XLAT scenario QMAP ID not updated in TX packets, due to that
it was not hitting not correct filter rules. Adding changes to
update QMAP ID field in metadata field for GSB client.
Change-Id: Ic6bfceb0b8e34316507eaf551fb2b62f085a3519
Whenever WAN CONS/WAN_COAL_CONS pipes setup fails,
cleaning up the allocated common buffer and temp pools.
Change-Id: I08c58d7bd36edbe820137d3fd760900598c4c8e6
Signed-off-by: Jagadeesh Ponduru <quic_jponduru@quicinc.com>
Currently WQ was exiting when page allocation was failed, due to
that number of WQ schedule will increase. To avoid this retrying the
page allocation in same WQ context.
Change-Id: Iefb85ae1552aa595a0959664c3ba55f6aa742551
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
Adding a change to check whether the pipe has been
setup or not before going to teardown the pipe.
Change-Id: Ibb408fdf3509facd6c18e3238bdbfd7da0b4a643
Signed-off-by: Jagadeesh Ponduru <quic_jponduru@quicinc.com>
After passing ipa_q6_clnt pointer to function, if it freed in
different thread it may lead to NULL pointer access. So adding
check to see passed pointer valid or not.
Change-Id: I22e272ebdecc62756ee140081524ab4efdd3d02a
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
Fix to NULL terminate the peers list ptr
after freeing it, to get rid of use after
free issue.
Change-Id: Ide9fde9e7648a7af561a5b0ae0fa085810e59ea6
Signed-off-by: Prashanth Reddy Baddam <quic_pbaddam@quicinc.com>
From IPAv4.5 versions IPA_TOS_EQ is considered as not supported
and it made to 0XFF, instead IPA_IS_PURE_ACK is given support.
So, when validating the bitfield equations of them, passing
eq_bitfield[i] will throw shift overflow warning as it takes 0xFF.
So, added change to ensure there are no overflow warnings.
Change-Id: I84384723433706784a4ef21b88f33b036edb0a5d
Signed-off-by: Jagadeesh Ponduru <quic_jponduru@quicinc.com>
Added some NULL checks to avoid memcpy with zero size,
Updated checks for unsigned integer variables.
Change-Id: Ia426da6b1af04fb5226ba9bbf22f0fce11e4dff0
Signed-off-by: Raghavendar rao l <quic_rlomte@quicinc.com>
Updated change to avoid race condition and NULL pointer access,
In case of SSR and ioctl call while performing QMI transaction.
Change-Id: I09dbf33d76a3a0d9e4917e62aaf1257a1abe2db9
Signed-off-by: Raghavendar rao l <quic_rlomte@quicinc.com>
In SSR scenario if QMI response delayed SSR events getting timeout,
To avoid this issue reduce the QMI timeout value from 60sec to 10sec.
Change-Id: Ib0113a91f9bd60b3ea0e374bf249d4859a22a040
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
Set the ipa3_ctx->logbuf NULL after destroy,or
IPAERR will use the ipa3_ctx->logbuf after free it,
that can make crash
Change-Id: I470c4a043d426d7620c01fadac1f1cd12ad54b08
The pointer should be event ring pointer, not transfer
ring pointer, it has chance to get wrong upper 32 bits
when smmu is disabled.
Signed-off-by: Cheng Zeng <quic_chenzeng@quicinc.com>
In deep sleep suspend/resume scenario destroy the uC interrupts
in suspend and reinitialize the interrupts in resume
Change-Id: Ib3631cef8e1e78651b6b79aef7f3d65dae0411c2
Signed-off-by: Ashok Vuyyuru <quic_avuyyuru@quicinc.com>
