Commit graph

1,025 commits

Author SHA1 Message Date
Haritha Chintalapati
99dff46326 Merge "msm: camera: isp: reduce bufdone error logs" into camera-kernel.lnx.4.0 2020-12-02 19:10:41 -08:00
Haritha Chintalapati
20e88f8b07 Merge "msm: camera: isp: Transition to HALT state prior to HW stop" into camera-kernel.lnx.4.0 2020-12-02 19:10:29 -08:00
Haritha Chintalapati
4a9c7c3e61 Merge "msm: camera: isp: Add null check for vfe out res data" into camera-kernel.lnx.4.0 2020-12-02 19:10:14 -08:00
Haritha Chintalapati
f0d94805f1 Merge "msm: camera: ope: Check array size of input sync obj" into camera-kernel.lnx.4.0 2020-12-02 19:10:00 -08:00
Haritha Chintalapati
974ca5d6f1 Merge "msm: camera: isp: Choose appropriate WM for frame header" into camera-kernel.lnx.4.0 2020-12-02 19:09:49 -08:00
Haritha Chintalapati
c1d9e46023 Merge "msm: camera: isp: Print the expected height & width" into camera-kernel.lnx.4.0 2020-12-02 19:09:36 -08:00
Haritha Chintalapati
d7cdc013ea Merge "msm: camera: isp: Update err type when notifying to HW MGR" into camera-kernel.lnx.4.0 2020-12-02 19:09:22 -08:00
Haritha Chintalapati
2d6e45797c Merge "msm: camera: reqmgr: check applied req id for sync mode" into camera-kernel.lnx.4.0 2020-12-02 19:09:10 -08:00
Haritha Chintalapati
56434293e9 Merge "msm: camera: common: Improve IFE and CRM Logging" into camera-kernel.lnx.4.0 2020-12-02 19:08:56 -08:00
Karthik Anantha Ram
b3f31ae726 msm: camera: isp: Transition to HALT state prior to HW stop
In case of any error IRQs encountered during stop, there is
no need to notify them to UMD since the entire pipeline
would be reset prior to next session start. With this change
we transition to HALT state and then issue stop.

CRs-Fixed: 2825121
Change-Id: I9535439d1a29e3b6f8da968b60e5b2b5bc32c1bf
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
2020-11-30 18:27:00 -08:00
Karthik Anantha Ram
b3b1177fdf msm: camera: isp: Print the expected height & width
In case of pix/line count error, print the configured
pixels and lines directly from the format measure config
register as opposed to the data from the blob.

CRs-Fixed: 2825795
Change-Id: I8cdfb5afbd8cf573abeb7d4e3522d24fa37d8201
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
2020-11-30 18:26:21 -08:00
Shravya Samala
c3c2045115 msm: camera: ope: Check array size of input sync obj
Incase of input buffer, check array size of input sync obj before assigning
fence.

CRs-Fixed: 2821583
Change-Id: I5cd7968cfbe0be86a8967565616bf6eb1cf7fcf7
Signed-off-by: Shravya Samala <shravyas@codeaurora.org>
2020-11-30 00:02:02 -08:00
Ayush Kumar
a73a482f76 msm: camera: isp: Add null check for vfe out res data
Fixes the null pointer dereference in the get Constraint error
function.

CRs-Fixed: 2825045
Change-Id: I72d8e51257fcfeca8386e626cf04db448bf3b483
Signed-off-by: Ayush Kumar <ayushkr@codeaurora.org>
2020-11-30 00:01:37 -08:00
Karthik Anantha Ram
b8fa562370 msm: camera: isp: Update err type when notifying to HW MGR
Currently violation in FULL IFE on IPP/PPP path is treated
as overflow in HW_MGR. Update the err type correctly.

CRs-Fixed: 2815428
Change-Id: I2bbcdca03afc5be48281c39c50ecb32342ad7fbe
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
2020-11-29 23:59:07 -08:00
Ravikishore Pampana
1f9cc4f48c msm: camera: isp: reduce bufdone error logs
If buf done error come for same applied request id then log
only once. Change the bufdone deferred logs to debug logs.

CRs-Fixed: 2824276
Change-Id: I870708bfb0c4f0ad0a1fade3a7e334551d055c73
Signed-off-by: Ravikishore Pampana <rpampana@codeaurora.org>
2020-11-25 23:14:20 +05:30
Karthik Anantha Ram
b9e826686f msm: camera: isp: Choose appropriate WM for frame header
Frame header is not enabled on all WMs. Currently frame header
is piggy backed with the first WM for which buffer is configured.
It is possible that this WM does not support frame header.
This change tries with all WMs till it finds a WM that supports
frame header.

CRs-Fixed: 2823154
Change-Id: I300cb449cdeebc74300d100dfdd8dbe50bec9bce
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
2020-11-24 15:55:14 -08:00
Haritha Chintalapati
ce18cf3937 Merge "msm: camera: cdm: Add more registers in cdm dump" into camera-kernel.lnx.4.0 2020-11-24 13:37:33 -08:00
Haritha Chintalapati
07152233db Merge "msm: camera: isp: Fix for NULL dereference for failure case of dual IFE" into camera-kernel.lnx.4.0 2020-11-23 16:55:01 -08:00
Haritha Chintalapati
9efbca83e5 Merge "msm: camera: sensor: Reset actuator flush requestId" into camera-kernel.lnx.4.0 2020-11-23 16:54:35 -08:00
Haritha Chintalapati
010a1e1426 Merge "msm: camera: reqmgr: Rate limit workq delay warning" into camera-kernel.lnx.4.0 2020-11-23 16:54:22 -08:00
Haritha Chintalapati
cf0971359d Merge "msm: camera: reqmgr: update timer even after skip frame" into camera-kernel.lnx.4.0 2020-11-23 16:54:03 -08:00
Haritha Chintalapati
9bc7143db7 Merge "msm: camera: icp: Check HW state prior to IRQ processing" into camera-kernel.lnx.4.0 2020-11-23 16:53:45 -08:00
Wyes Karny
c861a8d97a msm: camera: isp: Fix for NULL dereference for failure case of dual IFE
In the case of dual IFE acquire if left CSID reserve fails there is a
possibility of NULL pointer dereference.

CRs-Fixed: 2823225
Change-Id: Ib2bef582f69b245ee1d5b5b9ee8f5dacf8e2607a
Signed-off-by: Wyes Karny <wkarny@codeaurora.org>
2020-11-20 21:50:18 -08:00
Haritha Chintalapati
35c58f9297 Merge "msm: camera: reqmgr: Add checks before reporting the error" into camera-kernel.lnx.4.0 2020-11-20 14:15:03 -08:00
Sureshnaidu Laveti
6bbdcb3f6d msm: camera: sensor: Reset actuator flush requestId
When camera module shut down happens reset the
last flush request ID for the new session to
continue as fresh start.

CRs-Fixed: 2822543
Change-Id: Ic5b43d7acaeb7e7b6999c02cbb4654598469638b
Signed-off-by: Sureshnaidu Laveti <lsuresh@codeaurora.org>
2020-11-20 12:00:36 -08:00
Karthik Anantha Ram
b1c38c6f5a msm: camera: reqmgr: Rate limit workq delay warning
Rate limit log that indicates workq delay to reduce logging
impact.

CRs-Fixed: 2823945
Change-Id: I5954d5d08250955455003937e6490e4499a67378
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
2020-11-20 10:38:52 -08:00
Karthik Anantha Ram
ddfe75dc7a msm: camera: icp: Check HW state prior to IRQ processing
Check ICP HW state before processing any IRQ to avoid
any unclocked access.

CRs-Fixed: 2816854
Change-Id: I31fc03f655b1068f5d171385891eba7d281bd4fd
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
2020-11-19 18:19:36 -08:00
Camera Software Integration
c0bc075634 Merge "msm: camera: cpas: Update jpeg qosgen settings" into camera-kernel.lnx.4.0 2020-11-19 14:21:23 -08:00
Camera Software Integration
33c2430714 Merge "msm: camera: cpas: Enhance cpas dump with more info" into camera-kernel.lnx.4.0 2020-11-19 14:21:12 -08:00
Tejas Prajapati
b3673cb6b9 msm: camera: reqmgr: update timer even after skip frame
If Nth request has additional exposure timeout, after
applying sensor settings for Nth request; CRM watchdog
timer should be updated with the Nth requests additional
timeout on next frame irrespective of skip frame to
avoid sof freeze.

CRs-Fixed: 2802634
Change-Id: Iae70df66f0a1c22c2410e4826aea964ffd6d887b
Signed-off-by: Tejas Prajapati <tpraja@codeaurora.org>
2020-11-18 20:54:02 -08:00
Haritha Chintalapati
0166bc768c Merge "msm: camera: csiphy: CSIPHY DPHY DeSkew Calibration" into camera-kernel.lnx.4.0 2020-11-18 15:09:20 -08:00
Haritha Chintalapati
dd1071a4c6 Merge "msm: camera: utils: Rate limit error log in case of invalid handles" into camera-kernel.lnx.4.0 2020-11-17 14:09:34 -08:00
Ravikishore Pampana
e9fb6cfda6 msm: camera: reqmgr: Add checks before reporting the error
Add the null check for dev parameter before reporting the error on
link. Certain corner scenario for flash, send request return native
value in that case dev parameter could be null.

CRs-Fixed: 2814597
Change-Id: Ibe08f12c2f2c1864c46b17b0ae0f8df5c5648d35
Signed-off-by: Ravikishore Pampana <rpampana@codeaurora.org>
2020-11-17 06:06:25 -08:00
shiwgupt
60a0d836da msm: camera: csiphy: CSIPHY DPHY DeSkew Calibration
- Disable skew calibration by default for CSIPHY.

- When last bits of data are 0, Sensor flips data to static 1 in HS-Trail.
This creates a false calibration header in HS-Trail period depending on
last bits of data.

CRs-Fixed: 2777521
Change-Id: I285f74652cc3c8b74e280e7edfb92eb4661d2692
Signed-off-by: shiwgupt <shiwgupt@codeaurora.org>
2020-11-16 18:38:10 +05:30
Shravya Samala
99eaacc2c2 msm: camera: utils: Rate limit error log in case of invalid handles
Rate limit errors logs in case of incoming invalid handles
from userspace.

CRs-Fixed: 2807712
Change-Id: I3f8765be2f07f869149b9315ab38b7d02ae71a58
Signed-off-by: Shravya Samala <shravyas@codeaurora.org>
2020-11-16 02:33:52 -08:00
Pavan Kumar Chilamkurthi
4c4ed69a5c msm: camera: isp: Handle buf_done without request in active_list
In cases where we see a buf done without request being in
active_list, there could be a possibility that the request
is applied just before SOF, RUP but the context state is
not moved to Applied state, at this time the request is in
wait_list. In such cases RUP event doesn't move the request
into active_list. Also if the BUF_DONE on a port is happening
before EPOCH, we simply drop that BUF_DONE and then the request
will eventually be tagged as BUBBLE at the time of EPOCH. But
since BUF_DONE is dropped, the request will never come out of
BUBBLE. To handle such cases and to come out of BUBBLE,
check if BUF_DONE matches with the request in wait_list by
checking last_consumed address and if so, mark it as deferred
buf_done and handle once the request is moved to active_list.

CRs-Fixed: 2814346
Change-Id: I778a6a684076d5327d536f319a23206ccc0c25b6
Signed-off-by: Pavan Kumar Chilamkurthi <pchilamk@codeaurora.org>
2020-11-14 00:56:16 -08:00
Haritha Chintalapati
2dc8859361 Merge "msm: camera: isp: Bubble re-apply with CDM callback detect" into camera-kernel.lnx.4.0 2020-11-13 13:32:03 -08:00
Haritha Chintalapati
d9aa9104b8 Merge "msm: camera: ife: Fix Constraint error print" into camera-kernel.lnx.4.0 2020-11-12 13:44:51 -08:00
Alok Chauhan
6886644fec msm: camera: cpas: Update jpeg qosgen settings
Use OT limit as 10 for jpeg niu path. This help in
controlling jpeg bw flow and to avoid any backpressure
on IFE paths.

CRs-Fixed: 2802862
Change-Id: Iaaf9ef2a9ab6182aa7da1a160676a6e918454278
Signed-off-by: Alok Chauhan <alokc@codeaurora.org>
2020-11-12 10:00:58 +05:30
Haritha Chintalapati
31615a50c2 Merge "msm: camera: isp: Add checks to ensure valid out resource info in dump" into camera-kernel.lnx.4.0 2020-11-11 13:58:21 -08:00
Camera Software Integration
46d760366f Merge "msm: camera: isp: Add trigger id for EOF event" into camera-kernel.lnx.4.0 2020-11-11 13:57:44 -08:00
Jigar Agrawal
adfc0a0da2 msm: camera: cdm: Add more registers in cdm dump
Add more CDM registers in cdm dump function for better
debugging.

CRs-fixed: 2816605
Change-Id: I3925a094ee89e7f8f3d6ed6eead45c099ca4ac09
Signed-off-by: Jigar Agrawal <jigar@codeaurora.org>
2020-11-11 10:14:40 -08:00
Chandan Kumar Jha
5e697fee2a msm: camera: ife: Fix Constraint error print
Fixes the null pointer dereference in the print Constraint error
function.

CRs-Fixed: 2815855
Change-Id: I1ce982dd271e379b0a24e094b83a52f4dfb36e37
Signed-off-by: Chandan Kumar Jha <cjha@codeaurora.org>
2020-11-11 16:49:43 +05:30
chengxue
69fbe4cf55 msm: camera: reqmgr: check applied req id for sync mode
While links out of sync, one link faster than another.
the early link reset its slot while receive trigger from
isp, and the slow link will check ready always fail
on sync link, and stuck happens.

CRs-Fixed: 2800759
Change-Id: If615828304947d79ecbb2c87f03af29824598be0
Signed-off-by: chengxue <chengxue@codeaurora.org>
2020-11-10 23:05:00 -08:00
Wyes Karny
9075af0870 msm: camera: isp: Bubble re-apply with CDM callback detect
Re-apply bubble request if buf done has not come for 2 bubble frames.
Also before re-submitting the request to CDM check if CDM callback for that
request has come or not, if CDM callback is received then wait for buf
done else reset CDM and re-submit the request to CDM.

CRs-Fixed: 2807378
Change-Id: I1fd209482e14d58aa48d12194084d0a2ab943e31
Signed-off-by: Wyes Karny <wkarny@codeaurora.org>
2020-11-11 10:49:23 +05:30
Haritha Chintalapati
da1731a155 Merge "msm: camera: isp: Wait for cdm submit incase of custom HW" into camera-kernel.lnx.4.0 2020-11-10 18:13:19 -08:00
Haritha Chintalapati
b9c46ed8c0 Merge "msm: camera: custom: Add support for bubble handling" into camera-kernel.lnx.4.0 2020-11-10 18:13:10 -08:00
Haritha Chintalapati
17af990ff6 Merge "msm: camera: reqmgr: Remove idx check when detecting congestion" into camera-kernel.lnx.4.0 2020-11-10 18:12:57 -08:00
Jigar Agrawal
05abdc71b0 msm: camera: common: Improve IFE and CRM Logging
Improve IFE acquire logging and CRM SOF Freeze logging
for better debugging.

CRs-Fixed: 2812910
Change-Id: Ice9638872c9cf540b8721cd07f3d0c6b1f4b3bd4
Signed-off-by: Karthik Anantha Ram <kartanan@codeaurora.org>
Signed-off-by: Jigar Agrawal <jigar@codeaurora.org>
2020-11-10 16:56:07 -08:00
Haritha Chintalapati
22674ab994 Merge "msm: camera: isp: Fixing KW errors" into camera-kernel.lnx.4.0 2020-11-09 13:35:54 -08:00