Commit graph

1,031 commits

Author SHA1 Message Date
Satya Rama Aditya Pinapala
804f6e0de2 disp: msm: dsi: add check before buffer copy
This change adds a check for the length of the buffer
before copying it to avoid a buffer overflow.

Change-Id: I146895660be4060d9896706636257a57c6aef94f
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2019-07-23 09:22:26 -07:00
Satya Rama Aditya Pinapala
7b76eb582d disp: msm: dsi: deny an ESD trigger when not enabled
During an ESD trigger, a check must be done to ensure
that ESD is enabled on the particular panel. If not the
panel might end up in a bad state, if the trigger is
propagated successfully instead of reporting a failure.

Change-Id: I310578e7136301ab75ba7f44f14d36ed7e6a519c
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2019-07-23 09:21:40 -07:00
Nilaan Gunabalachandran
233ded8506 disp: msm: sde: consider num DS for mixer width
Helper function is returning the width of single mixer. During
atomic crtc check, the number of destination scaler is not
considered before width check and can fail possible higher
resolutions. The mixerwidth should be taken as a multiple of
num_ds_enabled.

Change-Id: Id9e5e0ccf0cebb54d2a242e039d8dc3676b3729f
Signed-off-by: Nilaan Gunabalachandran <ngunabal@codeaurora.org>
2019-07-23 12:20:41 -04:00
Satya Rama Aditya Pinapala
aacd9e9585 disp: msm: dp: adding prefix for logs
Adding prefixes for error, debug and info
messages in dp files. To enable debug logs
run "echo 0x100 > /sys/module/drm/parameters/debug"

CRs-Fixed: 2493739
Change-Id: Ibf509e837f527be6bff6b7a1c34b0cde2921b388
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2019-07-23 09:14:04 -07:00
Sankeerth Billakanti
9d0591d86f disp: msm: dp: correct the resolution width check in get_mode_info
Use two layer mixers only if the resolution of the display exceeds
the linewidth of the given layer mixer.

Change-Id: I1892587816c0718280765353df7eabf82d6d7a18
2019-07-23 04:13:13 -07:00
qctecmdr
a6bfb7fc1e Merge "disp: msm: dsi: adding prefix for logs" 2019-07-23 01:20:03 -07:00
qctecmdr
d393bfcf01 Merge "disp: msm: dp: split host init and deinit" 2019-07-22 23:21:57 -07:00
qctecmdr
04dcddd7c0 Merge "disp: msm: dsi: update default physical panel width and height" 2019-07-22 21:20:22 -07:00
Tatenda Chipeperekwa
a382d900a3 disp: msm: hdcp: update encryption level on framework request
Update the minimum encryption level only when there is a request
to do so coming from the DRM framework. This will ensure that any
previously set value will not be overwritten while processing
other commands. Failure to preserve the minimum encryption level
can result in secure content playback failure if the sink device
is not updated with the correct value.

Change-Id: Ie9a555a57617096fbdb9e46dd29a973b9223e237
Signed-off-by: Tatenda Chipeperekwa <tatendac@codeaurora.org>
2019-07-22 17:59:50 -07:00
Satya Rama Aditya Pinapala
e52bd3228c disp: msm: dsi: make PPS delay configurable
This change makes the post PPS command delay a panel property.
By default the value is set to zero if not specified.

Change-Id: I50c86ba0f0cb28ff617435e92e9675e5c35404ca
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2019-07-22 17:48:51 -07:00
Satya Rama Aditya Pinapala
6c483e3b23 disp: msm: dsi: adding prefix for logs
Adding debug, info and error prefix for log messages
in dsi files. To enable debug logs
run "echo 0x1 > /sys/module/drm/parameters/debug"

Change-Id: I438ac16954bd1d39450f8adeb7fb17f9ea6f8140
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2019-07-22 17:43:35 -07:00
qctecmdr
708c74de1e Merge "drm/msm: allow sde_atrace to show up on different process" 2019-07-22 17:35:07 -07:00
qctecmdr
c8aa6f7e44 Merge "drm/msm: enable counter trace" 2019-07-22 15:50:30 -07:00
qctecmdr
f95b75fdc6 Merge "drm/msm/sde: fix unpaired sde trace" 2019-07-22 13:55:17 -07:00
qctecmdr
3588284310 Merge "disp: msm: sde: fix cwb, dp and wb tear down sequence" 2019-07-22 11:52:53 -07:00
Ajay Singh Parmar
59008eabf8 disp: msm: dp: split host init and deinit
Break the host initialization and de-initialization to
create late initialization and early de-initialization.
Call host init/deinit on physical connect/disconnect only
As attention messages from sink doesn't change the physical
cable configurations, call only late init/early deinit in
this case to avoid unnecessary hardware resources
re-initialization.

CRs-Fixed: 2490128
Change-Id: Ib930d250724ab3ea811a7388c7ad0aeae1164e21
Signed-off-by: Ajay Singh Parmar <aparmar@codeaurora.org>
2019-07-19 13:45:56 -07:00
qctecmdr
82a67564fb Merge "disp: msm: dsi: signal pending clock change in case of DMS" 2019-07-19 05:17:06 -07:00
qctecmdr
829a9ba490 Merge "disp: msm: sde: correct the highest bank bit configuration." 2019-07-19 05:17:06 -07:00
qctecmdr
f23d62f8b1 Merge "disp: msm: dsi: update DSI PHY sequence for Kona" 2019-07-19 05:17:06 -07:00
qctecmdr
e9482e9e43 Merge "disp: msm: dsi: update dsi pclk in panel mode settings" 2019-07-19 05:17:06 -07:00
qctecmdr
9e4f9dab61 Merge "disp: msm: dsi: remove using static memory for roi commands" 2019-07-19 05:17:06 -07:00
qctecmdr
6db1b4cad1 Merge "disp: msm: dsi: Set the panel test gpio to input" 2019-07-19 05:17:06 -07:00
qctecmdr
73175fb95a Merge "disp: msm: sde: Correct initialization value for frame count" 2019-07-19 05:17:05 -07:00
Yuan Zhao
f2fdcee320 disp: msm: dsi: Set the panel test gpio to input
This GPIO is a input signal, so need to set it
to input mode, or it will lead leakage in RBC.
This change is only to fix the power issue.

Change-Id: I87716f646c75dac2f1350a2ea55188829a4ccc9e
Signed-off-by: Yuan Zhao <yzhao@codeaurora.org>
2019-07-19 00:52:34 -07:00
Yuan Zhao
a7b5db0465 disp: msm: dsi: Add a new DT property panel test pin
This pin is a output pin from panel. Panel can
output signal of internal VSYNC and ERR_FLAG.

Change-Id: Ib8e661ca1fdb33bb7060935edb9bc1f1a858c4b3
Signed-off-by: Yuan Zhao <yzhao@codeaurora.org>
2019-07-18 23:01:02 -07:00
Vara Reddy
30d6730b20 disp: msm: dsi: update dsi pclk in panel mode settings
Change calculates and updates correct pclk that is being
used to drm modes in kilo hertz.

Change-Id: I7aab10c08689697120d4d7c152f30993defd36d3
Signed-off-by: Vara Reddy <varar@codeaurora.org>
2019-07-18 15:42:01 -07:00
Vara Reddy
8915522efc disp: msm: dsi: remove using static memory for roi commands
Partial update commands are using static memory. For dual dsi,
both dsi's can manipulate on same memory, if partial update is enabled
on both of them. Change removes the static configuration.

Change-Id: I0ca16324a27427d13deaa9d18e3ab4f47fe1cc21
Signed-off-by: Vara Reddy <varar@codeaurora.org>
2019-07-18 14:23:28 -07:00
Dhaval Patel
bcd97aa368 disp: msm: sde: fix cwb, dp and wb tear down sequence
CWB, DP and WB displays tear down sequence must reset
3d_merge, ctl, pingpong_binding, etc. MDP HW
blocks. This change fixes the tear down
sequence register programming. It also moves flush
sw reset before encoder_disable call. That allows
CWB tear down to update the flush configuration
on primary ctl path.

Change-Id: I21c521b39456af4144cf836c65d46a25c985f51d
Signed-off-by: Dhaval Patel <pdhaval@codeaurora.org>
2019-07-18 14:13:33 -07:00
Satya Rama Aditya Pinapala
db61fc7518 disp: msm: dsi: update DSI PHY sequence for Kona
This change updates the DSI PHY sequence for Kona target as
per latest HW team recommendation.

Change-Id: I20f6a81bb1112e9e976acae595b985dad7ad4b7a
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2019-07-18 13:59:05 -07:00
Satya Rama Aditya Pinapala
7ea04a4d47 disp: pll: update DSI PHY PLL programming for Kona
This change updates the DSI PHY PLL programming for kona target
as per the hardware recommendation.

Change-Id: I706169fb635e72bd0ccd3057107ea749408733d0
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2019-07-18 12:41:38 -07:00
Adrian Salido
beb2d1b584 drm/msm: allow sde_atrace to show up on different process
Currently trace always shows up on same process as caller, add
an additional function to allow attaching trace to any process.

Change-Id: I8fc124f9d1cfae28d1868a9a3067d0e92eda934e
Signed-off-by: Adrian Salido <salidoa@google.com>
(cherry picked from commit 52ba2d3585eb49c5d5b90b3cd75e0abe5c984dad)
Signed-off-by: Christopher Braga <cbraga@codeaurora.org>
Signed-off-by: Samantha Tran <samtran@codeaurora.org>
2019-07-18 10:36:47 -07:00
Adrian Salido
1bb14cd806 drm/msm: enable counter trace
Trace counter is not properly showing up on trace as is. Replace it with
proper format by refactoring existing trace to be more generic.

Bug: 119295905
Change-Id: I50abb593cd67c10ceed115380ac0e9d2177f0963
Signed-off-by: Adrian Salido <salidoa@google.com>
(cherry picked from commit 89ac1949eaa1524e4e2bbd2ad8c8b6513ae594dd)
Signed-off-by: Christopher Braga <cbraga@codeaurora.org>
Signed-off-by: Samantha Tran <samtran@codeaurora.org>
2019-07-18 10:36:39 -07:00
Midas Chien
216abbf9fa drm/msm/sde: fix unpaired sde trace
Unpaired trace "sde_power_resource_enable" caused tracer parse
incorrect trace points and display weird state on Chrome. Make
trace "sde_power_resource_enable" pair to fix it.

Bug: 122510119
Test: Checked sde trace can be displayed correctly on Chrome
Change-Id: I938b5648a09e00eaea59070af31a2e6469763087
Signed-off-by: Midas Chien <midaschieh@google.com>
(cherry picked from commit 3a335059bf7a200977e8f4e0a4aa5c6ceca3863a)
Signed-off-by: Christopher Braga <cbraga@codeaurora.org>
Signed-off-by: Samantha Tran <samtran@codeaurora.org>
2019-07-18 10:36:25 -07:00
qctecmdr
984f48452d Merge "Revert "disp: msm: dsi: update DSI PHY sequence for Kona"" 2019-07-17 18:29:00 -07:00
Vara Reddy
4920154558 disp: msm: dsi: update default physical panel width and height
Change updates connector edid node with proper panel physical
dimensions based on panel device tree file.

Change-Id: I36db9c3e5b5aee926a0d029ae742166fc8c7591c
Signed-off-by: Vara Reddy <varar@codeaurora.org>
2019-07-17 17:22:20 -07:00
Vara Reddy
6c456bad33 disp: msm: dsi: batch max packet size command with read command
Change batches max packet size and read command together, so that
for each esd read, there will not be two independent command transfers.
Without batching sometimes esd thread can hold the panel mutex for
longer time, which can cause framedrops as crtc thread can be blocked on
panel lock to send partial update command and kickoff next frame.

Change-Id: I101283a2559b616911f4312421acb00a8f154dba
Signed-off-by: Vara Reddy <varar@codeaurora.org>
2019-07-17 15:41:30 -07:00
Ping Li
652b195ba4 disp: msm: sde: Add LTM sw fuse check support
Add checks for LTM sw fuse value to only install the LTM properties
when the LTM sw fuse is set to enable.

Change-Id: I6876bfcf12ddb912e7b7a80e07c33108fd4b85b9
Signed-off-by: Ping Li <pingli@codeaurora.org>
2019-07-17 13:03:39 -07:00
Yuan Zhao
fdaf7b0e21 disp: msm: Use the new notifier function instead of msm_drm_notifier
Since other driver module could not use msm_drm function,
then the notify function was moved to drm_panel. So used
the new drm_panel notify API instead of the old one.

Change-Id: I053992d74125807ccbf8991e3ac771dfc3eef732
Signed-off-by: Yuan Zhao <yzhao@codeaurora.org>
2019-07-17 05:02:54 -07:00
Prashant Singh
45f02bb102 disp: msm: sde: correct the highest bank bit configuration.
Highest bank bit property is read from device-tree, else set
to default value based on DDR type.

Change-Id: I8b31d957e29071b599a7f983cbf8300e293e9e36
Signed-off-by: Prashant Singh <prasin@codeaurora.org>
2019-07-17 16:29:57 +05:30
Yuan Zhao
51ca5e052c disp: msm: sde: Set drm_panel to drm_connector
Set drm_panel to drm_connector. It can get drm_panel
from connector for other usage.

Change-Id: I68430be8aa05f140b88592c38db8e79aa96dafe6
Signed-off-by: Yuan Zhao <yzhao@codeaurora.org>
2019-07-17 00:32:55 -07:00
Yuan Zhao
df6d76968e disp: msm: dsi: Add a new function to get drm_panel
A new API to get drm_panel from dsi_display.
The drm_panel was defined as a member of drm_connector.
When doing connector initialize, can set drm_panel to
drm_connector. So this API is needed to get drm_panel
from dsi_dsiplay.

Change-Id: I0ec9de5a9407085048a8fef421b7b28d466085ed
Signed-off-by: Yuan Zhao <yzhao@codeaurora.org>
2019-07-16 19:32:37 -07:00
qctecmdr
dbbb358a92 Merge "disp: pll: fix sequence as per hardware recommendations" 2019-07-16 17:21:08 -07:00
Satya Rama Aditya Pinapala
07f4b98ff4 Revert "disp: msm: dsi: update DSI PHY sequence for Kona"
This reverts commit 03295175d6.

Change-Id: I9e31e27196f7ee82f2355bf1300a7895ef8e1306
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2019-07-16 13:46:10 -07:00
Satya Rama Aditya Pinapala
094f183278 disp: msm: dsi: signal pending clock change in case of DMS
When there is a change in resolution or FPS, a new clock rate is
calculated. During such a Dynamic Mode Switch, the clock rate
change pending flag needs to be set after it has been calculated.
This flag is later checked before kickoff and the clocks are updated
accordingly.

Change-Id: Iec102796d5c61d01c567f0b6676e9a6d4ed94268
Signed-off-by: Satya Rama Aditya Pinapala <psraditya30@codeaurora.org>
2019-07-16 10:48:39 -07:00
Nilaan Gunabalachandran
e87d8f7cc5 disp: msm: sde: Secondary display lm preference with lm pair
When secondary display preference is determined and 2 layer
mixers are required, the preference must check LM pair mask
to meet hw restrictions.

Change-Id: I22845be84f95659a58be98ff11afa4e652fb16e3
Signed-off-by: Nilaan Gunabalachandran <ngunabal@codeaurora.org>
2019-07-15 11:22:09 -04:00
qctecmdr
ab1d40154f Merge "disp: msm: dp: Reset dp sink power state during panel init" 2019-07-13 02:06:28 -07:00
qctecmdr
3e7ef1e1d0 Merge "disp: msm: dsi: Remove drm_panel tracking from sde_connector" 2019-07-13 00:16:26 -07:00
qctecmdr
a990883c59 Merge "disp: msm: remove unnecessary vblank get and put" 2019-07-12 22:05:06 -07:00
qctecmdr
b700d98e0e Merge "disp: msm: dp: filter modes based on sde resource availability" 2019-07-12 16:50:22 -07:00
Ajay Singh Parmar
e0e4280214 disp: pll: fix sequence as per hardware recommendations
Update the PLL and PHY power on and clock set sequence as per
the hardware recommendations. Move the post link clock phy enable
part to the catalog so that it can be programmed after enabling
link clock.

Change-Id: I9b3b49e5a9ac93bebcb1cb7da63b715a8d5ed85c
Signed-off-by: Ajay Singh Parmar <aparmar@codeaurora.org>
2019-07-12 16:44:05 -07:00