Daniel Jordan
0685dfa0a2
padata: validate cpumask without removed CPU during offline ...
[ Upstream commit 894c9ef9780c5cf2f143415e867ee39a33ecb75d ]
Configuring an instance's parallel mask without any online CPUs...
echo 2 > /sys/kernel/pcrypt/pencrypt/parallel_cpumask
echo 0 > /sys/devices/system/cpu/cpu1/online
...makes tcrypt mode=215 crash like this:
divide error: 0000 [#1 ] SMP PTI
CPU: 4 PID: 283 Comm: modprobe Not tainted 5.4.0-rc8-padata-doc-v2+ #2
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS ?-20191013_105130-anatol 04/01/2014
RIP: 0010:padata_do_parallel+0x114/0x300
Call Trace:
pcrypt_aead_encrypt+0xc0/0xd0 [pcrypt]
crypto_aead_encrypt+0x1f/0x30
do_mult_aead_op+0x4e/0xdf [tcrypt]
test_mb_aead_speed.constprop.0.cold+0x226/0x564 [tcrypt]
do_test+0x28c2/0x4d49 [tcrypt]
tcrypt_mod_init+0x55/0x1000 [tcrypt]
...
cpumask_weight() in padata_cpu_hash() returns 0 because the mask has no
CPUs. The problem is __padata_remove_cpu() checks for valid masks too
early and so doesn't mark the instance PADATA_INVALID as expected, which
would have made padata_do_parallel() return error before doing the
division.
Fix by introducing a second padata CPU hotplug state before
CPUHP_BRINGUP_CPU so that __padata_remove_cpu() sees the online mask
without @cpu. No need for the second argument to padata_replace() since
@cpu is now already missing from the online mask.
Fixes: 33e5445068linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-02-24 08:36:34 +01:00
bpf, devmap: Pass lockdep expression to RCU lists
2020-02-11 04:35:29 -08:00
cgroup: Prevent double killing of css when enabling threaded cgroup
2020-02-05 21:22:42 +00:00
kgdb: don't use a notifier to enter kgdb at panic; call directly
2019-09-25 17:51:40 -07:00
dma-direct: don't check swiotlb=force in dma_direct_map_resource
2020-01-26 10:01:08 +01:00
perf/core: Fix mlock accounting in perf_mmap()
2020-02-11 04:35:54 -08:00
Revert "um: Enable CONFIG_CONSTRUCTORS"
2020-02-01 09:34:53 +00:00
x86/apic/msi: Plug non-maskable MSI affinity race
2020-02-11 04:35:54 -08:00
livepatch: Nullify obj->mod in klp_module_coming()'s error path
2019-08-19 13:03:37 +02:00
locking/lockdep: Fix buffer overrun problem in stack_trace[]
2020-01-23 08:22:39 +01:00
ACPI: PM: s2idle: Avoid possible race related to the EC GPE
2020-02-19 19:52:56 +01:00
printk: fix exclusive_console replaying
2020-02-24 08:36:24 +01:00
rcu: Fix data-race due to atomic_t copy-by-value
2020-02-24 08:36:23 +01:00
sched/uclamp: Reject negative values in cpu_uclamp_write()
2020-02-19 19:53:07 +01:00
clocksource: Prevent double add_timer_on() for watchdog_timer
2020-02-11 04:35:54 -08:00
tracing: Simplify assignment parsing for hist triggers
2020-02-24 08:36:31 +01:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
audit/stable-5.3 PR 20190702
2019-07-08 18:55:42 -07:00
audit/stable-5.3 PR 20190702
2019-07-08 18:55:42 -07:00
audit_get_nd(): don't unlock parent too early
2019-11-10 11:56:55 -05:00
audit/stable-5.3 PR 20190702
2019-07-08 18:55:42 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500
2019-06-19 17:09:55 +02:00
kernel/configs: Replace GPL boilerplate code with SPDX identifier
2019-07-30 18:34:15 +02:00
cpu/hotplug, stop_machine: Fix stop_machine vs hotplug order
2020-02-24 08:36:23 +01:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 230
2019-06-19 17:09:06 +02:00
keys: Fix request_key() cache
2020-01-17 19:48:42 +01:00
kernel/elfcore.c: include proper prototypes
2019-09-25 17:51:39 -07:00
exit: panic before exit_mm() on global init exit
2020-01-09 10:20:01 +01:00
extable: Add function to search only kernel exception table
2019-08-21 22:23:48 +10:00
clone3: ensure copy_thread_tls is implemented
2020-01-14 20:08:35 +01:00
Revert "libata, freezer: avoid block device removal while system is frozen"
2019-10-06 09:11:37 -06:00
futex: Prevent exit livelock
2019-11-29 10:10:14 +01:00
kheaders: substituting --sort in archive creation
2019-10-17 09:08:19 +09:00
mm/nvdimm: add is_ioremap_addr and use that to check ioremap address
2019-07-12 11:05:40 -07:00
jump_label: Don't warn on __exit jump entries
2019-08-29 15:10:10 +01:00
kallsyms: Don't let kallsyms_lookup_size_offset() fail on retrieving the first symbol
2019-08-27 16:19:56 +01:00
sched/rt, Kconfig: Unbreak def/oldconfig with CONFIG_PREEMPT=y
2019-07-22 18:05:11 +02:00
kexec_load: Disable at runtime if the kernel is locked down
2019-08-19 21:54:15 -07:00
kexec: bail out upon SIGKILL when allocating memory.
2019-09-25 17:51:40 -07:00
kexec_elf: support 32 bit ELF files
2019-09-06 23:58:44 +02:00
Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security
2019-09-28 08:14:15 -07:00
Tracing updates:
2019-09-20 11:19:48 -07:00
kthread: make __kthread_queue_delayed_work static
2019-10-16 09:20:58 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
Merge branch 'next-integrity' of git://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity
2019-09-27 19:37:27 -07:00
modules: lockdep: Suppress suspicious RCU usage warning
2020-02-24 08:36:33 +01:00
MODSIGN: Export module signature definitions
2019-08-05 18:39:56 -04:00
MODSIGN: Export module signature definitions
2019-08-05 18:39:56 -04:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
padata: validate cpumask without removed CPU during offline
2020-02-24 08:36:34 +01:00
panic: ensure preemption is disabled during panic()
2019-10-07 15:47:19 -07:00
lockdown: Lock down module params that specify hardware parameters (eg. ioport)
2019-08-19 21:54:16 -07:00
kernel/pid.c: convert struct pid count to refcount_t
2019-07-16 19:23:24 -07:00
proc/sysctl: add shared variables for range check
2019-07-18 17:08:07 -07:00
ptrace: reintroduce usage of subjective credentials in ptrace_has_cap()
2020-01-23 08:22:36 +01:00
mm/memory_hotplug.c: use PFN_UP / PFN_DOWN in walk_system_ram_range()
2019-09-24 15:54:09 -07:00
seccomp: Check that seccomp_notif is zeroed out by the user
2020-01-09 10:19:57 +01:00
cgroup: freezer: call cgroup_enter_frozen() with preemption disabled in ptrace_stop()
2019-10-11 08:39:57 -07:00
smp: Warn on function calls from softirq context
2019-07-20 11:27:16 +02:00
Merge branch 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-07-08 11:01:13 -07:00
stacktrace: Don't skip first entry on noncurrent tasks
2019-11-04 21:19:25 +01:00
stop_machine: Avoid potential race behaviour
2019-10-17 12:47:12 +02:00
Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-09-17 12:35:15 -07:00
arch: handle arches who do not yet define clone3
2019-06-21 01:54:53 +02:00
kernel: sysctl: make drop_caches write-only
2020-01-04 19:18:32 +01:00
taskstats: fix data-race
2020-01-09 10:19:54 +01:00
torture: Remove exporting of internal functions
2019-08-01 14:30:22 -07:00
The main changes in this release include:
2019-07-18 11:51:00 -07:00
proc/sysctl: add shared variables for range check
2019-07-18 17:08:07 -07:00
smp: Remove smp_call_function() and on_each_cpu() return values
2019-06-23 14:26:26 +02:00
Keyrings namespacing
2019-07-08 19:36:47 -07:00
Keyrings namespacing
2019-07-08 19:36:47 -07:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
watchdog: Mark watchdog_hrtimer to expire in hard interrupt context
2019-08-01 20:51:20 +02:00
workqueue: Add RCU annotation for pwq list walk
2020-01-26 10:01:07 +01:00
0685dfa0a2