Tom Zanussi
201fdd62bb
tracing: Simplify assignment parsing for hist triggers
...
[ Upstream commit b527b638fd63ba791dc90a0a6e9a3035b10df52b ]
In the process of adding better error messages for sorting, I realized
that strsep was being used incorrectly and some of the error paths I
was expecting to be hit weren't and just fell through to the common
invalid key error case.
It also became obvious that for keyword assignments, it wasn't
necessary to save the full assignment and reparse it later, and having
a common empty-assignment check would also make more sense in terms of
error processing.
Change the code to fix these problems and simplify it for new error
message changes in a subsequent patch.
Link: http://lkml.kernel.org/r/1c3ef0b6655deaf345f6faee2584a0298ac2d743.1561743018.git.zanussi@kernel.org
Fixes: e62347d245 ("tracing: Add hist trigger support for user-defined sorting ('sort=' param)")
Fixes: 7ef224d1d0 ("tracing: Add 'hist' event trigger command")
Fixes: a4072fe85b ("tracing: Add a clock attribute for hist triggers")
Reported-by: Masami Hiramatsu <mhiramat@kernel.org>
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Tom Zanussi <zanussi@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-02-24 08:36:31 +01:00
..
blktrace.c
blktrace: no need to check return value of debugfs_create functions
2019-06-03 15:39:39 +02:00
bpf_trace.c
bpf: Make use of probe_user_write in probe write helper
2020-01-17 19:48:40 +01:00
fgraph.c
ftrace: Look up the address of return_to_handler() using helpers
2019-09-18 12:24:47 +10:00
ftrace.c
ftrace: Protect ftrace_graph_hash with ftrace_sync
2020-02-11 04:35:28 -08:00
ftrace_internal.h
treewide: Rename rcu_dereference_raw_notrace() to _check()
2019-08-01 14:16:21 -07:00
Kconfig
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2019-09-18 12:34:53 -07:00
Makefile
power-traces.c
preemptirq_delay_test.c
ring_buffer.c
tracing: Do not create directories if lockdown is in affect
2020-01-12 12:21:45 +01:00
ring_buffer_benchmark.c
tracing: Use CONFIG_PREEMPTION
2019-07-31 19:03:35 +02:00
rpm-traces.c
trace.c
tracing: Do not set trace clock if tracefs lockdown is in effect
2020-01-29 16:45:25 +01:00
trace.h
ftrace: Protect ftrace_graph_hash with ftrace_sync
2020-02-11 04:35:28 -08:00
trace_benchmark.c
trace_benchmark.h
trace_branch.c
trace_clock.c
trace_dynevent.c
tracing: Add tracing_check_open_get_tr()
2019-10-12 20:44:07 -04:00
trace_dynevent.h
tracing/dynevent: Pass extra arguments to match operation
2019-08-31 12:19:38 -04:00
trace_entries.h
trace_event_perf.c
tracing: Fix race in perf_trace_buf initialization
2019-10-21 19:38:28 -04:00
trace_events.c
tracing: Fix lock inversion in trace_event_enable_tgid_record()
2020-01-09 10:19:59 +01:00
trace_events_filter.c
tracing: Avoid memory leak in process_system_preds()
2020-01-09 10:20:00 +01:00
trace_events_filter_test.h
trace_events_hist.c
tracing: Simplify assignment parsing for hist triggers
2020-02-24 08:36:31 +01:00
trace_events_trigger.c
tracing: trigger: Replace unneeded RCU-list traversals
2020-01-29 16:45:25 +01:00
trace_export.c
trace_functions.c
trace_functions_graph.c
fgraph: Remove redundant ftrace_graph_notrace_addr() test
2019-07-30 21:50:03 -04:00
trace_hwlat.c
tracing/hwlat: Don't ignore outer-loop duration when calculating max_latency
2019-10-12 20:49:33 -04:00
trace_irqsoff.c
trace_kdb.c
tracing: Silence GCC 9 array bounds warning
2019-05-25 23:04:30 -04:00
trace_kprobe.c
tracing/uprobe: Fix to make trace_uprobe_filter alignment safe
2020-02-05 21:22:53 +00:00
trace_kprobe_selftest.c
trace_kprobe_selftest.h
trace_mmiotrace.c
trace_nop.c
trace_output.c
tracing: Be more clever when dumping hex in __print_hex()
2019-09-17 11:21:28 -04:00
trace_output.h
trace_preemptirq.c
trace_printk.c
tracing: Add locked_down checks to the open calls of files created for tracefs
2019-10-12 20:48:06 -04:00
trace_probe.c
tracing/kprobes: Have uname use __get_str() in print_fmt
2020-02-11 04:35:07 -08:00
trace_probe.h
tracing/uprobe: Fix to make trace_uprobe_filter alignment safe
2020-02-05 21:22:53 +00:00
trace_probe_tmpl.h
tracing/probe: Support user-space dereference
2019-05-25 23:04:42 -04:00
trace_sched_switch.c
tracing: Fix sched switch start/stop refcount racy updates
2020-02-11 04:35:07 -08:00
trace_sched_wakeup.c
kernel/trace: Fix do not unregister tracepoints when register sched_migrate_task fail
2020-01-14 20:08:22 +01:00
trace_selftest.c
trace_selftest_dynamic.c
trace_seq.c
trace_stack.c
tracing: Have stack tracer compile when MCOUNT_INSN_SIZE is not defined
2020-01-14 20:08:22 +01:00
trace_stat.c
tracing: Fix very unlikely race of registering two stat tracers
2020-02-24 08:36:30 +01:00
trace_stat.h
trace_syscalls.c
trace_uprobe.c
tracing/uprobe: Fix to make trace_uprobe_filter alignment safe
2020-02-05 21:22:53 +00:00
tracing_map.c
tracing: Have the histogram compare functions convert to u64 first
2020-01-09 10:20:00 +01:00
tracing_map.h