No description
  • C 98.2%
  • Assembly 1%
  • Makefile 0.3%
  • Shell 0.2%
  • Python 0.1%
Find a file
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Hemant Kumar 66a6e72914 usb: dwc3: Issue core soft reset upon controller halt failure
In case of composition switch there is a possibility of run/stop
bit gets cleared in the middle of a control transfer. If controller
has cached a SETUP packet but not yet written it to ep0 TRB, controller
halt fails even if there are no pending events in event ring. As part of
pull up enable run/stop bit gets set and control transfer starts, due to
that controller writes cached SETUP packet to ep0 TRB and triggers xfer
completion. Since run/stop bit is set Host issues bus reset and end
transfer and Halt are issued on ep0 because ep0 is not in SETUP phase.
However this does not recover the controller's ep0 state machine. As a
result controller is unable to handle SET ADDRESS SETUP packet issued by
host.

Before completing data stage of control transfer if vbus disconnects
controller halt fails even after issuing end transfer cmd on ep0 IN.
There is a possibility of race between controller accessing the ep0
buffer from cached TRB which was queued in data stage of control
transfer and end xfer command completion. This is resulting into
accessing of TRB buffer after controller halt failure by this time
buffer is already unmapped by dwc3_remove_requests().

Fix above issues by issuing core soft reset if control halt fails to
prevent controller from accessing cached TRB buffer. Also move issuing
of end xfer command for ep0 IN before un-mapping the ep0 TRB buffer in
case ep0 state is not in SETUP phase in dwc3_remove_requests().

Change-Id: Ie159e06a2537afcc9deee3f6670aac5d66b97b90
Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
Signed-off-by: Elson Roy Serrao <eserrao@codeaurora.org>
2019-11-20 14:37:57 -08:00
arch Merge "arm64: defconfig: Enable CVP driver" 2019-11-15 18:10:52 -08:00
block Linux 5.4-rc6 2019-11-04 06:51:47 +01:00
certs PKCS#7: Refactor verify_pkcs7_signature() 2019-08-05 18:40:18 -04:00
crypto Merge branch 'next-lockdown' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security 2019-09-28 08:14:15 -07:00
Documentation Merge remote-tracking branch 'remotes/origin/tmp-aefd2d632eb0' into msm-lahaina 2019-11-04 17:30:19 -08:00
drivers usb: dwc3: Issue core soft reset upon controller halt failure 2019-11-20 14:37:57 -08:00
fs Linux 5.4-rc6 2019-11-04 06:51:47 +01:00
include Merge "ASoC: msm: Add compressed TX and passthrough support" 2019-11-18 21:08:04 -08:00
init Merge remote-tracking branch 'remotes/origin/tmp-aefd2d632eb0' into msm-lahaina 2019-11-04 17:30:19 -08:00
ipc Merge 5.4-rc1-prelrease into android-mainline 2019-10-02 17:58:47 +02:00
kernel Merge remote-tracking branch 'remotes/origin/tmp-aefd2d632eb0' into msm-lahaina 2019-11-04 17:30:19 -08:00
lib Merge remote-tracking branch 'remotes/origin/tmp-aefd2d632eb0' into msm-lahaina 2019-11-04 17:30:19 -08:00
LICENSES
mm Merge remote-tracking branch 'remotes/origin/tmp-aefd2d632eb0' into msm-lahaina 2019-11-04 17:30:19 -08:00
net Merge remote-tracking branch 'remotes/origin/tmp-aefd2d632eb0' into msm-lahaina 2019-11-04 17:30:19 -08:00
samples samples/bpf: Add a workaround for asm_inline 2019-10-03 17:37:11 +02:00
scripts Merge remote-tracking branch 'remotes/origin/tmp-aefd2d632eb0' into msm-lahaina 2019-11-04 17:30:19 -08:00
security Linux 5.4-rc6 2019-11-04 06:51:47 +01:00
sound ASoC: core: add debug log for cpu dais 2019-11-18 15:55:10 +08:00
techpack techpack: Fix uapi headers_install 2019-10-29 15:31:14 -07:00
tools USB fixes for 5.4-rc6 2019-11-03 08:25:25 -08:00
usr kbuild: update compile-test header list for v5.4-rc2 2019-10-05 15:29:49 +09:00
virt kvm: call kvm_arch_destroy_vm if vm creation fails 2019-10-31 12:13:16 +01:00
.clang-format clang-format: Update with the latest for_each macro list 2019-08-31 10:00:51 +02:00
.cocciconfig
.get_maintainer.ignore
.gitattributes
.gitignore Merge remote-tracking branch 'remotes/origin/tmp-3fde1dfb006c' into msm-lahaina 2019-10-23 14:22:32 -07:00
.mailmap A few MIPS fixes: 2019-10-26 19:43:12 -04:00
abi_gki_aarch64.xml Update ABI definition after libabigail upgrade 2019-09-22 10:51:50 +01:00
abi_gki_aarch64_c249464.xml Subject: [PATCH 2/3] ABI: aarch64: Update ABI snapshot based on v5.4-rc6 2019-11-12 16:51:04 -08:00
build.config.aarch64 ANDROID: refactor build.config files to remove duplication 2019-08-30 14:55:29 +01:00
build.config.allmodconfig ANDROID: Remove KVM_INTEL allmodconfig workaround 2019-10-31 10:52:27 -07:00
build.config.allmodconfig.aarch64 ANDROID: create build.configs for allmodconfig 2019-09-04 15:49:40 +00:00
build.config.allmodconfig.x86_64 ANDROID: create build.configs for allmodconfig 2019-09-04 15:49:40 +00:00
build.config.common build.config.*: Link android-mainline kernels with LLD 2019-10-25 18:56:06 +00:00
build.config.gki ANDROID: refactor build.config files to remove duplication 2019-08-30 14:55:29 +01:00
build.config.gki.aarch64 ANDROID: refactor build.config files to remove duplication 2019-08-30 14:55:29 +01:00
build.config.gki.x86_64 ANDROID: refactor build.config files to remove duplication 2019-08-30 14:55:29 +01:00
build.config.x86_64 ANDROID: refactor build.config files to remove duplication 2019-08-30 14:55:29 +01:00
COPYING
CREDITS MAINTAINERS: Remove Simon as Renesas SoC Co-Maintainer 2019-10-10 08:12:51 -07:00
Kbuild kbuild: do not descend to ./Kbuild when cleaning 2019-08-21 21:03:58 +09:00
Kconfig docs: kbuild: convert docs to ReST and rename to *.rst 2019-06-14 14:21:21 -06:00
MAINTAINERS Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2019-11-01 17:48:11 -07:00
Makefile Merge remote-tracking branch 'remotes/origin/tmp-aefd2d632eb0' into msm-lahaina 2019-11-04 17:30:19 -08:00
README
README.md ANDROID: Fix typo for FROMLIST: section 2019-10-29 20:31:07 +00:00

How do I submit patches to Android Common Kernels

  1. BEST: Make all of your changes to upstream Linux. If appropriate, backport to the stable releases. These patches will be merged automatically in the corresponding common kernels. If the patch is already in upstream Linux, post a backport of the patch that conforms to the patch requirements below.

  2. LESS GOOD: Develop your patches out-of-tree (from an upstream Linux point-of-view). Unless these are fixing an Android-specific bug, these are very unlikely to be accepted unless they have been coordinated with kernel-team@android.com. If you want to proceed, post a patch that conforms to the patch requirements below.

Common Kernel patch requirements

  • All patches must conform to the Linux kernel coding standards and pass script/checkpatch.pl
  • Patches shall not break gki_defconfig or allmodconfig builds for arm, arm64, x86, x86_64 architectures (see https://source.android.com/setup/build/building-kernels)
  • If the patch is not merged from an upstream branch, the subject must be tagged with the type of patch: UPSTREAM:, BACKPORT:, FROMGIT:, FROMLIST:, or ANDROID:.
  • All patches must have a Change-Id: tag (see https://gerrit-review.googlesource.com/Documentation/user-changeid.html)
  • If an Android bug has been assigned, there must be a Bug: tag.
  • All patches must have a Signed-off-by: tag by the author and the submitter

Additional requirements are listed below based on patch type

Requirements for backports from mainline Linux: UPSTREAM:, BACKPORT:

  • If the patch is a cherry-pick from Linux mainline with no changes at all
    • tag the patch subject with UPSTREAM:.
    • add upstream commit information with a (cherry-picked from ...) line
    • Example:
      • if the upstream commit message is
        important patch from upstream

        This is the detailed description of the important patch

        Signed-off-by: Fred Jones <fred.jones@foo.org>
    - then Joe Smith would upload the patch for the common kernel as
        UPSTREAM: important patch from upstream

        This is the detailed description of the important patch

        Signed-off-by: Fred Jones <fred.jones@foo.org>

        Bug: 135791357
        Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01
        (cherry-picked from c31e73121f4c1ec41143423ac6ce3ce6dafdcec1)
        Signed-off-by: Joe Smith <joe.smith@foo.org>
  • If the patch requires any changes from the upstream version, tag the patch with BACKPORT: instead of UPSTREAM:.
    • use the same tags as UPSTREAM:
    • add comments about the changes under the (cherry-picked from ...) line
    • Example:
        BACKPORT: important patch from upstream

        This is the detailed description of the important patch

        Signed-off-by: Fred Jones <fred.jones@foo.org>

        Bug: 135791357
        Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01
        (cherry-picked from c31e73121f4c1ec41143423ac6ce3ce6dafdcec1)
        [ Resolved minor conflict in drivers/foo/bar.c ]
        Signed-off-by: Joe Smith <joe.smith@foo.org>

Requirements for other backports: FROMGIT:, FROMLIST:,

  • If the patch has been merged into an upstream maintainer tree, but has not yet been merged into Linux mainline
    • tag the patch subject with FROMGIT:
    • add info on where the patch came from as (cherry picked from commit <sha1> <repo> <branch>). This must be a stable maintainer branch (not rebased, so don't use linux-next for example).
    • if changes were required, use BACKPORT: FROMGIT:
    • Example:
      • if the commit message in the maintainer tree is
        important patch from upstream

        This is the detailed description of the important patch

        Signed-off-by: Fred Jones <fred.jones@foo.org>
    - then Joe Smith would upload the patch for the common kernel as
        FROMGIT: important patch from upstream

        This is the detailed description of the important patch

        Signed-off-by: Fred Jones <fred.jones@foo.org>

        Bug: 135791357
        (cherry picked from commit 878a2fd9de10b03d11d2f622250285c7e63deace
         https://git.kernel.org/pub/scm/linux/kernel/git/foo/bar.git test-branch)
        Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01
        Signed-off-by: Joe Smith <joe.smith@foo.org>
  • If the patch has been submitted to LKML, but not accepted into any maintainer tree
    • tag the patch subject with FROMLIST:
    • add a Link: tag with a link to the submittal on lore.kernel.org
    • if changes were required, use BACKPORT: FROMLIST:
    • Example:
        FROMLIST: important patch from upstream

        This is the detailed description of the important patch

        Signed-off-by: Fred Jones <fred.jones@foo.org>

        Bug: 135791357
        Link: https://lore.kernel.org/lkml/20190619171517.GA17557@someone.com/
        Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01
        Signed-off-by: Joe Smith <joe.smith@foo.org>

Requirements for Android-specific patches: ANDROID:

  • If the patch is fixing a bug to Android-specific code
    • tag the patch subject with ANDROID:
    • add a Fixes: tag that cites the patch with the bug
    • Example:
        ANDROID: fix android-specific bug in foobar.c

        This is the detailed description of the important fix

        Fixes: 1234abcd2468 ("foobar: add cool feature")
        Change-Id: I4caaaa566ea080fa148c5e768bb1a0b6f7201c01
        Signed-off-by: Joe Smith <joe.smith@foo.org>
  • If the patch is a new feature
    • tag the patch subject with ANDROID:
    • add a Bug: tag with the Android bug (required for android-specific features)