Continuation headers baffle checkpatch, as it can only operate
on one line of context at a time. When continuation headers are found,
put them up with the header they're continuing so the whole thing
can be parsed in a single line of context.
Change-Id: I2d22ed056f8203ae6dae473b01ae66bc1963ae75
Signed-off-by: Gregory Bean <gbean@codeaurora.org>
Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Signed-off-by: Raghavendra Rao Ananta <rananta@codeaurora.org>
Initial ABI definition file which was checked in is not
based on "gki_defconfig". Which is generated with ARCH_QCOM
enabled. This adds extra QCOM functions which we do not want
to care about. Intention of ABI checker is to figure out
whether the base ABI file is modified/removed/impacted. If
there are any additions (functions/structures) that happened
and if it does not impact the base ABI then it should be ok
from the ABI checker perspective.
Change-Id: Ic9eb7fad33ab6f076f637523d21d33451a369068
Signed-off-by: Murali Nalajala <mnalajal@codeaurora.org>
smp_processor_id() complains if called from a preemptible
context. Hence, disable the preemption just before calling
this and enable it back later.
Change-Id: I6721796d11186eb15021b37d5ea8250afa0edda0
Signed-off-by: Raghavendra Rao Ananta <rananta@codeaurora.org>
Enable ARM JTAG DCC driver to get the kernel logs on trace32
term window.
Change-Id: Ic0e9d0d89c82d43985dd123a6c5e13287a2fbf0f
Signed-off-by: Raghavendra Rao Ananta <rananta@codeaurora.org>
Some debuggers, such as Trace32 from Lauterbach GmbH, do not handle
reads/writes from/to DCC on secondary cores. Each core has its
own DCC device registers, so when a core reads or writes from/to DCC,
it only accesses its own DCC device. Since kernel code can run on
any core, every time the kernel wants to write to the console, it
might write to a different DCC.
In SMP mode, Trace32 only uses the DCC on core 0. In AMP mode, it
creates multiple windows, and each window shows the DCC output
only from that core's DCC. The result is that console output is
either lost or scattered across windows.
Selecting this option will enable code that serializes all console
input and output to core 0. The DCC driver will create input and
output FIFOs that all cores will use. Reads and writes from/to DCC
are handled by a workqueue that runs only core 0.
Change-Id: I1e83d254ff2feaf235d212571ed791a9e84e547f
Acked-by: Adam Wallis <awallis@codeaurora.org>
Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
Signed-off-by: Kyle Yan <kyan@codeaurora.org>
Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Add initial ABI definition file based on gki_defconfig.
This denition file is used in the automation while the
new changes are merge into the kernel. This process
detects ABI break if the new changes are introduced
any API/structure changes which could impact the other
exported functions or modules.
This initial snapshot is taken from the commit 553049f.
Initial definition present in the current directory is
also based on gki_config i.e abi_gki_aarch64.out, But
this definition can't be used for ABI comparision because
of compiler being used to generate this file could be
different. Hence generate the one by our own and maintain
the same.
Change-Id: I3a5a744e81a004659065c1b44c98baddfa242fbb
Signed-off-by: Murali Nalajala <mnalajal@codeaurora.org>
If code is merged upstream first it is possible that the same author
may end up attempting to merge the same code into a downstream kernel.
Since code coming from upstream is always a backport and may involve
modifications it is appropriate for the author to add another
Signed-off-by line to the bottom of the commit log but this will
cause checkpatch to complain about duplicate signatures. By making
the duplicate signature warning a different error class
(DUPLICATE_SIGN_OFF instead of BAD_SIGN_OFF) this will let us ignore
this error with --ignore DUPLICATE_SIGN_OFF without losing the benefits
of the other signature checks.
Change-Id: Ic0dedbadcc1b319061db324f88740e5320bfff09
Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>
Exempt copyright statements from the 80 column rule as line-splitting or
other kinds of work-arounds decrease readability in diffs. Identify the
copyright statement by looking for '+/* Copyright (c)', case-insensitive,
at the beginning of the line.
Change-Id: I57aafd569ff2173ca7aa3f636532060fc93b2be1
Signed-off-by: Bryan Huntsman <bryanh@codeaurora.org>
Upstream has merged a few commit text length checks
that make our own checks redundant. Furthermore,
upstream also has a newer exception list (such as
allowing Fixes: lines to be >75 characters) that
we should take advantage of.
Change-Id: I894482c1a4182ad71146d5d433610d4cb210cb1d
Signed-off-by: Vikram Mulukutla <markivx@codeaurora.org>
Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Rather than forcing authors of reverts to truncate the summary line
because the "Revert" prefix added pushes it over the character limit,
excuse reverts from this rule.
Change-Id: I395dfff3327e360ef935d4a685c38df6577e3867
Signed-off-by: Matt Wagantall <mattw@codeaurora.org>
Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Commit text is almost always necessary to explain why a change is
needed. Exceptions are rare enough that these can be granted through
manual checkpatch overrides.
Change-Id: I926b2276f717940c2fec77a6709fa3088b1bf0c3
Signed-off-by: Steve Muckle <smuckle@codeaurora.org>
Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
When patches contain extended character sets, patches will contain
MIME headers after the subject line, which should not be confused
for a too-long summary line.
Change-Id: I66f70b465ef804444a3bdb49867654b5613b13a7
Signed-off-by: Gregory Bean <gbean@codeaurora.org>
(cherry picked from commit 8e6b9d3790595198a34320f1c3f4504cd258fed1)
Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Checkpatch is throwing a warning for lines that contains file delta
in the commit log.
WARNING: Possible unwrapped commit description
(prefer a maximum 75 chars per line)
kerneldir/msm-abc-xyz123.dtsi
| 68 ++++++++++++++++++++++++++++++++++++++++----
This file delta line of the patch should be ignored for maximum characters
per line check and is taken care of already, but it's not covering if the
file has '-' in its name. Update the conditional check to cover this case.
Change-Id: If37691aa897f8a991c1643a08fbde45cc4afaaf7
Signed-off-by: Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>
Warn on summary or commit text lines greater than 75 characters.
The summary and commit text are indented and may wrap on a terminal
if they are longer than 75 characters.
Change-Id: I37b13dc870cb797980ffdd978ebf3e15bb624afa
Signed-off-by: David Keitel <dkeitel@codeaurora.org>
Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Now that mb() does what we want, dsb() should be discouraged.
Change-Id: Ib8fe8f44f669753c3d91fac3c6e598e117d6d90e
Signed-off-by: Gregory Bean <gbean@codeaurora.org>
(cherry picked from commit 9c0619be7b93ad114d6f33a749d905ddff93df7d)
Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
Fixed case when no warning generated for long subject line that is
wrapped to more than one line, and all lines are less than line limit.
New warning message added:
"non-blank line after summary line"
Now there are two warnings possible for the subject line, the original
line over limit and the new one. Depending on the error(s) any
combination of the two warnings are possible.
Commit text requirements now:
1) Must be less than 75 characters
2) Must be followed by blank line.
Change-Id: Id28d7a2eee561a1b1f45e51e346be3868c1fbad5
Signed-off-by: David Keitel <dkeitel@codeaurora.org>
Currently checkpatch.pl throws error for any use of "dsb"
keyword. Add exceptions when it is used in a variable or a
function name. Expectations are when 'dsb' keyword is used in a
variable or a function name, it is prefixed with class [-_>*\.]
and/or suffixed with class [-_\.;].
Change-Id: I06cd21e42135334bb41cf31f13088b118fcf3ac9
Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
filp_open allows people to get around the ban on sys_open.
Close the loophole.
Change-Id: I6e2be62e848cbc064e07008d0886c0d003c8be4b
Signed-off-by: Gregory Bean <gbean@codeaurora.org>
(cherry picked from commit bb181a18a813a70176f71a0c64aa572fcfbef0f0)
Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Improve parsing of multiline macros which run beyond the available
diff context. These beyond-the-horizon macros previously caused
two distinct naughty behaviors:
- The scanner, confused by the trailing backslash, would grab
the header of the next context hunk and treat it as the last
line of the preceding macro.
- The analyzer, unable to fully reduce the macro, would blame
the patch for submitting an unbalanced or unprotected macro.
Change-Id: I6b7dd3d577c524d30b59dff7b20393bb5135f16d
Signed-off-by: Gregory Bean <gbean@codeaurora.org>
(cherry picked from commit ddd028c47b4d91aa9c0e97445eb584b2de367769)
Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
Unbounded string functions are overflow risks. The 'n'
versions of those functions should be used instead.
Change-Id: Ice0fb3ebdae9aa88cc7e764ffdf68cbed857febf
Signed-off-by: Gregory Bean <gbean@codeaurora.org>
(cherry picked from commit 15e1e97d66dd6a6039c1ec2bd549a632fe361128)
Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
Forbid read[bwl], write[bwl], in[bwl], and out[bwl], as they
contain a 'stealth barrier' which can harm performance.
Developers are expected to call appropriate __raw_* or *_relaxed
APIs and manage barriers explicitly.
Change-Id: Ie4da221c91a0505917199db9e2fdb704c3e47d44
Signed-off-by: Gregory Bean <gbean@codeaurora.org>
(cherry picked from commit 032fd4ba09e195d9913c08f460130da9905936ef)
Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
Use of the sys_open/close/read/write system calls from within
kernel code is inappropriate, and now triggers errors.
Change-Id: I98e20513c257d0664684b7144585853f617d771a
Signed-off-by: Gregory Bean <gbean@codeaurora.org>
(cherry picked from commit ee62f2afcac1bcb180b2f0dddf2c8f5cda54bc5b)
Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
[abhimany: resolve trivial merge conflicts]
Signed-off-by: Abhimanyu Kapur <abhimany@codeaurora.org>
The only legal integer return is 0, anything else
following "return" should be -ERRCODE or a function.
http://lkml.org/lkml/2010/7/23/318
There's lots of "return -1;" statements in this patch - it's obscene
that this is used to indicate "some error occurred" in kernel space
rather than a real errno value - even when an existing function
(eg, request_irq) gave you an error code already.
Please note this for the future - and please review patches on this
point internally first.
Change-Id: I16268b2ee034f0b3b899115e45c28acfa734ddec
Signed-off-by: Patrick Pannuto <ppannuto@codeaurora.org>
(cherry picked from commit 39531a47164294315b5a7256b520fe22d6e87013)
Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
Discourage the use of mdelay(), and use msleep() instead.
Change-Id: I99f44fc632df4b371bc8633005d57c220ece1001
Signed-off-by: Israel Schlesinger <israels@codeaurora.org>
(cherry picked from commit 084af58596758be6e51ef060aefa2cd622dc9205)
Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
Signed-off-by: Raghavendra Rao Ananta <rananta@codeaurora.org>
Add CLK_* macros used in MSM clock drivers to the list of exceptions
for the "Macros with complex values should be enclosed in parenthesis"
test.
Also, allow spaces following open branckets for macros where the
macro is the first token on the line, the space preceds a decimal
number, and the line ends with ")," or ")". Such arrangements can
be useful for aligning numerical columns of tables when the rows
are described by macros.
Change-Id: I7701119ada2ea8fd646e5448eae51786bbf1e8fa
Signed-off-by: Matt Wagantall <mattw@codeaurora.org>
(cherry picked from commit ed6d6ed1c6b8f6016ea5676d075331e31b7ac1f8)
Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
Enable CONFIG_LAHAINA option to use Lahaina platforms
such as RUMI, MTP, CDP and QRD.
Change-Id: I7cd1cf766ecda58fd4adf0428f320bd0b16841fe
Signed-off-by: Raghavendra Rao Ananta <rananta@codeaurora.org>
Add vendor directory to the devicetree makefile. This directory
will be included in the compilation only if it's present.
Change-Id: Ib644d00fd61469afa2311d214866607b78220f71
Signed-off-by: Venkata Narendra Kumar Gutta <vnkgutta@codeaurora.org>
Signed-off-by: Raghavendra Rao Ananta <rananta@codeaurora.org>
The device-tree bindings directory no longer contains the
Makefile that the Documentation/Makefile is looking for.
Hence, to avoid compilation issues, ignore the part where
it looks for the bindings' Makefile.
Change-Id: I6477f1b75697e0b9b9edf537b585a58d89dedfbf
Signed-off-by: Raghavendra Rao Ananta <rananta@codeaurora.org>
Add initial defconfig fragments, such as lahaina_GKI.config,
lahaina_QGKI.config, and lahaina_debug.config, for the
Lahaina platform.
Change-Id: I019a941d5bae5e043feb2e4d43f450332b795881
Signed-off-by: Raghavendra Rao Ananta <rananta@codeaurora.org>
Add scripts to enable a build system to compile GKI
based kernels. Specifically, the scripts allows the
build systems to build a particular variant of defconfig
and a menuconfig interface to edit fragments.
Change-Id: I26399ce1911f9484650bb9ee4658c4043c5c556c
Signed-off-by: Raghavendra Rao Ananta <rananta@codeaurora.org>
This is a snapshot of build scripts taken as of msm-4.19
commit <3fc21416733e696> (Merge "ARM: dts: msm: Add dpdm
regulator on kona").
Change-Id: I3a60f8563227de4e6f59d5abcca7c8edd2c8c12f
Signed-off-by: Raghavendra Rao Ananta <rananta@codeaurora.org>
Suppress the SDLLVM specific compiler warning (undefined optimized)
for the compilation to pass. Also add -fno-builtin such that the
build doesn't pickup any compiler provided built-in functions.
Change-Id: I9507600a9286ec6aff42160d2d77733594b891de
Signed-off-by: Raghavendra Rao Ananta <rananta@codeaurora.org>
The build system assumes that the clang version string is found in the
first line of the clang --version output. However, this is not true
for SDLLVM. Hence, look for the string in the entire output, rather
than just the first line.
Change-Id: I2db999e616f4e5ceedb5c0081d6440bbd5c3f52e
Signed-off-by: Raghavendra Rao Ananta <rananta@codeaurora.org>
abi_gki_aarch64.out contains the ABI definition corresponding to the
current sources and the configuration referred to in
build.config.gki.aarch64.
As part of the build.sh tooling it will be copied over into the
distribution for further inspection / analysis. See
https://android-review.googlesource.com/970737 for details on that
process.
This is the initial version of this definition to allow implementation
of workflows around it. It is not considered stable at this point. It is
expected that it will break with significant changes from either
upstream or with changes implemented specific for this tree. Automated
validation is supposed to catch differences between this definition and
the actual binary before they are introduced into the tree. At a later
stage this validation should be part of build.sh itself.
Bug: 133501930
Change-Id: I815940ee13037ad450547e0ab0786e37f0b83d9b
Signed-off-by: Matthias Maennich <maennich@google.com>
